Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI Spec & Merge Files API #139

Merged
merged 48 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
f019a94
Propagate headers through API Client
mgyucht Aug 14, 2023
269105e
remove unused code
mgyucht Aug 14, 2023
13a15c9
almost there
mgyucht Aug 15, 2023
2e7b3d0
tests are passing
mgyucht Aug 15, 2023
a9c6b98
better test compat
mgyucht Aug 15, 2023
6de6e0f
Mostly there
mgyucht Aug 16, 2023
78589ff
Merge branch 'main' into propagate-headers-to-apiclient
mgyucht Aug 16, 2023
3153753
Merge branch 'propagate-headers-to-apiclient' into support-inputstrea…
mgyucht Aug 16, 2023
1a3aff8
tweaks
mgyucht Aug 18, 2023
851ee5b
some work
mgyucht Aug 18, 2023
618ef9e
some more work
mgyucht Aug 18, 2023
1468c85
tweaks
mgyucht Aug 18, 2023
293ac5c
update log4j.properties
mgyucht Aug 18, 2023
3030303
Merge branch 'main' into support-inputstream-for-request-and-response…
mgyucht Aug 18, 2023
6f68bbf
Merge branch 'main' into propagate-headers-to-apiclient
mgyucht Aug 18, 2023
9b0c29c
regen
mgyucht Aug 18, 2023
858ffb5
some cleanup
mgyucht Aug 18, 2023
bb84dff
some fixes
mgyucht Aug 18, 2023
de469bb
tweaks
mgyucht Aug 18, 2023
628a50a
use main
mgyucht Aug 18, 2023
596fed6
Looking good
mgyucht Aug 18, 2023
0a2ef75
Merge branch 'propagate-headers-to-apiclient' into support-inputstrea…
mgyucht Aug 18, 2023
ec87fcb
run on master
mgyucht Aug 18, 2023
4200686
on this branch
mgyucht Aug 18, 2023
6045d89
move to right branch
mgyucht Aug 18, 2023
5edeb41
with filesapi
mgyucht Aug 18, 2023
0d30290
address comments
mgyucht Aug 18, 2023
8a522ba
Merge branch 'propagate-headers-to-apiclient' into support-inputstrea…
mgyucht Aug 18, 2023
29109c1
address comments
mgyucht Aug 18, 2023
e390283
remove extra file
mgyucht Aug 18, 2023
2a6cfaa
Merge branch 'propagate-headers-to-apiclient' into support-inputstrea…
mgyucht Aug 18, 2023
c2a8444
Merge branch 'support-inputstream-for-request-and-response-bodies' in…
mgyucht Aug 18, 2023
45976f5
work
mgyucht Aug 18, 2023
44a0e4a
Merge branch 'main' into files-openapi
mgyucht Aug 23, 2023
697306f
bump openapi
mgyucht Aug 23, 2023
0fdcd6c
clear out old stuff
mgyucht Aug 23, 2023
ccf2fe9
remove unused
mgyucht Aug 23, 2023
ac55d23
Merge branch 'main' into files-openapi
mgyucht Aug 25, 2023
f6fb8d4
Merge Files API
mgyucht Aug 25, 2023
90616c4
update openapi spec
mgyucht Aug 25, 2023
6eda050
remove initial slash
mgyucht Aug 25, 2023
f6ceb1d
Support UCWS tests
mgyucht Aug 26, 2023
d532390
fmt
mgyucht Aug 26, 2023
75592dd
fix httpclient
mgyucht Aug 26, 2023
e2aca56
fmt
mgyucht Aug 28, 2023
1ca49f3
leave original behavior
mgyucht Aug 28, 2023
f9e2188
test getStatus as well
mgyucht Aug 28, 2023
27fa3fd
fmt
mgyucht Aug 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen/_openapi_sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
beff621d7b3e1d59244e2e34fc53a496f310e130
be3d4a799362f0d5ddbfeb0a0acdfb91f8736a3b
63 changes: 36 additions & 27 deletions .gitattributes

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ private Response computeResponse(Request in, CloseableHttpResponse response) thr
boolean streamResponse =
in.getHeaders().containsKey("Accept")
&& !APPLICATION_JSON.getMimeType().equals(in.getHeaders().get("Accept"))
&& hs.containsKey("Content-Type")
Copy link
Contributor Author

@mgyucht mgyucht Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because header keys are not case-sensitive (esp. if response is HTTP 2.0, which enforces header keys to be lower case). In theory, the same check applies to request headers, but we know the case used because we control it.

&& !APPLICATION_JSON.getMimeType().equals(hs.get("Content-Type").get(0));
&& !APPLICATION_JSON.getMimeType().equals(response.getFirstHeader("Content-Type").getValue());
if (streamResponse) {
CustomCloseInputStream inputStream =
new CustomCloseInputStream(
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading