Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Files API integration test #150

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fix Files API integration test #150

merged 1 commit into from
Sep 8, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Sep 8, 2023

Changes

The order of required args to create a volume was updated in #148.

Tests

Integration tests now pass.

@pietern
Fix Files API integration test
d7c47f1 
The order of required args to create a volume was updated in #148.
tanmay-db
tanmay-db approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@tanmay-db tanmay-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@tanmay-db tanmay-db added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 4a40b53 Sep 8, 2023
9 checks passed
@tanmay-db tanmay-db deleted the fix-volumes-nightly branch September 8, 2023 08:06
tanmay-db added a commit that referenced this pull request Sep 11, 2023
@tanmay-db
Release v0.8.1
7645645 
* Fix Files API integration test ([#150](#150)).
* [DECO-2483] Handle Azure authentication when WorkspaceResourceID is provided ([#145](#145)).
@tanmay-db tanmay-db mentioned this pull request Sep 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2023
@tanmay-db
Release v0.8.1 (#152)
0337b77 
* Added support for Azure authentication when WorkspaceResourceID is
provided
([#145](#145)).
* Fixed Files API integration test
([#150](#150)).

Integration tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht

@kartikgupta-db kartikgupta-db Awaiting requested review from kartikgupta-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietern @tanmay-db