Refactor ChannelTestBase to replace mocks #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqtab
changed the title
kafka-connect/src/test/java/io/tabular/iceberg/connect/channel/CoordinatorTest.java
Show resolved
Hide resolved
tabmatfournier
approved these changes
Mar 11, 2024
fqtab
commented
Mar 11, 2024
| @@ -65,9 +65,9 @@ public void testCommitResponseSerialization() { | |||
| assertThat(payload.commitId()).isEqualTo(commitId); | |||
| assertThat(payload.tableName().toIdentifier()).isEqualTo(TableIdentifier.parse("db.tbl")); | |||
| assertThat(payload.dataFiles()).hasSize(2); | |||
| assertThat(payload.dataFiles()).allMatch(f -> f.specId() == 1); | |||
| assertThat(payload.dataFiles()).allMatch(f -> f.specId() == 0); | |||
There was a problem hiding this comment.
for posterity's sake, this change is because the createDataFile function now creates files with unpartitioned spec.
| null, | ||
| null, | ||
| 1); | ||
| return DataFiles.builder(PartitionSpec.unpartitioned()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
ChannelTestBaseto use "real" catalog and table implementations rather than mocks.In my next PR, I have to use iceberg's transaction functionality and mocking out that functionality didn't seem worth it.