[Feature] Add `databricks_app` resource #4099

nkvuong · 2024-10-12T10:22:44Z

Changes

Added databricks_app resource

Resolves #4084

Tests

make test run locally
relevant change in docs/ folder
covered with integration tests in internal/acceptance
relevant acceptance tests are passing
using Go SDK

alexott

small changes in the doc required, otherwise code looks good

apps/resource_app.go

docs/resources/app.md

andrewnester · 2024-11-14T10:44:28Z

apps/resource_app.go

+				return err
+			}
+			// now deploy the app, using the source code path
+			createAppDeployment.AppName = app.Name


I think we discussed it offline and agreed that the deployment won't be part of TF configuration. Instead, if an users want to deploy, they use CLI to do that. Otherwise it's confusing because we do the deployments only when source_code_path changed but we need to do deployments when source code is changed.

@pietern wdyt?

andrewnester · 2024-11-14T10:44:50Z

apps/resource_app.go

+			if err != nil {
+				return err
+			}
+			if d.HasChanges("source_code_path", "mode") {


See my comment above, I think we should remove app deployment altogether for now

andrewnester · 2024-11-21T12:58:20Z

Just to clarify, I mean app resource needs to be added here so it can be part of the schema and be able to use it by DABs since we rely on generic databricks_permission resource anyway
https://github.com/databricks/terraform-provider-databricks/blob/main/permissions/permission_definitions.go#L346

…-provider-databricks into feature/app

nkvuong · 2024-11-22T08:13:22Z

@andrewnester makes sense - I've added apps to the permission resource and corresponding tests

mgyucht

Behavior-wise, this seems OK to me. Can we use the plugin framework to implement this instead of the SDKv2? We're trying to move away from SDkv2 to plugin framework for all new resources.

mgyucht · 2024-11-26T08:45:10Z

apps/resource_app.go

+	appNameValidationFunc := validation.StringMatch(
+		regexp.MustCompile("^[a-z-]{2,30}$"),
+		"name must contain only lowercase alphanumeric characters and hyphens, and be between 2 and 30 characters long")


Let's leave validation out and let server perform validation instead.

mgyucht · 2024-11-26T08:49:00Z

apps/resource_app.go

+		"update_time", "updater", "url"} {
+		s.SchemaPath(p).SetComputed()
+	}
+	return s


Let's at least do the validation in the create/update. (Or at least test to verify what its behavior is.)

mgyucht · 2024-11-26T08:56:18Z

apps/resource_app.go

+			if err != nil {
+				return err
+			}
+			_, err = w.Apps.Update(ctx, apps.UpdateAppRequest{


Do we need to wait for state (like in create)?

mgyucht · 2024-11-26T08:59:13Z

apps/resource_app.go

+				}
+				return err
+			}
+			d.SetId(app.Name)


Can we update this to get it back into a healthy state? if not this is fine. If so, let's set the ID before waiting for ready, then subsequent applies can call update.

mgyucht · 2024-11-26T10:16:39Z

apps/resource_app.go

+)
+
+var appAliasMap = map[string]string{
+	"resources": "resource",


@rauchy Can you discuss with @nkvuong about adding this alias to our API spec?

mgyucht · 2024-11-26T10:16:53Z

apps/resource_app.go

+	}
+}
+
+func ResourceApp() common.Resource {


BTW: Can we use the plugin framework for this new resource? Generally speaking, new resources should use the plugin framework, since it should be much more consistent for handling things like effective fields, dealing with lists, etc.

mgyucht · 2024-11-26T12:25:37Z

docs/resources/app.md

+
+-> This feature is in [Public Preview](https://docs.databricks.com/release-notes/release-types.html).
+
+Apps run directly on a customer’s Databricks instance, integrate with their data, use and extend Databricks services, and enable users to interact through single sign-on.


Can we link to public docs about Apps?

mgyucht · 2024-11-26T12:25:59Z

docs/resources/app.md

+
+-> This feature is in [Public Preview](https://docs.databricks.com/release-notes/release-types.html).
+
+Apps run directly on a customer’s Databricks instance, integrate with their data, use and extend Databricks services, and enable users to interact through single sign-on.


We should probably mention that this only creates the application and doesn't do anything with the app deployment.

github-actions · 2024-11-27T06:18:13Z

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

PR number: 4099
Commit SHA: 2bac7aa7cc25a9ad8aebc939fe3ef965cdf6e84b

Checks will be approved automatically on success.

eng-dev-ecosystem-bot · 2024-11-27T06:18:38Z

Test Details: go/deco-tests/12044847955

nkvuong and others added 5 commits October 12, 2024 18:22

added databricks_app resource

c8859e2

wip

962d9f2

add doc

2e9137a

alias

91b5166

Merge branch 'main' into feature/app

bcf2a97

nkvuong temporarily deployed to test-trigger-is October 29, 2024 09:48 — with GitHub Actions Inactive

nkvuong marked this pull request as ready for review October 29, 2024 09:48

nkvuong requested review from a team as code owners October 29, 2024 09:48

nkvuong requested review from mgyucht and removed request for a team October 29, 2024 09:48

fix

35b85eb

nkvuong temporarily deployed to test-trigger-is October 29, 2024 09:59 — with GitHub Actions Inactive

fix test

9c7ad60

nkvuong temporarily deployed to test-trigger-is October 30, 2024 06:25 — with GitHub Actions Inactive

fix test

863fa37

nkvuong temporarily deployed to test-trigger-is October 30, 2024 08:41 — with GitHub Actions Inactive

fix

2d7b38c

nkvuong temporarily deployed to test-trigger-is October 30, 2024 12:54 — with GitHub Actions Inactive

alexott requested changes Nov 6, 2024

View reviewed changes

apps/resource_app.go Outdated Show resolved Hide resolved

docs/resources/app.md Outdated Show resolved Hide resolved

docs/resources/app.md Outdated Show resolved Hide resolved

andrewnester reviewed Nov 14, 2024

View reviewed changes

andrewnester requested a review from pietern November 14, 2024 10:46

Merge branch 'main' into feature/app

b733ee9

nkvuong temporarily deployed to test-trigger-is November 14, 2024 11:07 — with GitHub Actions Inactive

feedback

ff8bee8

nkvuong temporarily deployed to test-trigger-is November 14, 2024 11:36 — with GitHub Actions Inactive

fix test

0daeea1

nkvuong temporarily deployed to test-trigger-is November 15, 2024 00:07 — with GitHub Actions Inactive

andrewnester self-requested a review November 21, 2024 12:58

andrewnester mentioned this pull request Nov 21, 2024

Added support for Databricks Apps in DABs databricks/cli#1928

Open

1 task

add app permission

8338d09

nkvuong temporarily deployed to test-trigger-is November 22, 2024 02:38 — with GitHub Actions Inactive

Merge branch 'main' into feature/app

c6ee7ea

nkvuong temporarily deployed to test-trigger-is November 22, 2024 02:38 — with GitHub Actions Inactive

nkvuong added 2 commits November 22, 2024 11:29

fix test

07ea8b7

Merge branch 'feature/app' of https://github.com/databricks/terraform…

3b1f6e2

…-provider-databricks into feature/app

nkvuong temporarily deployed to test-trigger-is November 22, 2024 03:30 — with GitHub Actions Inactive

more computed fields

9e41c69

nkvuong temporarily deployed to test-trigger-is November 22, 2024 08:11 — with GitHub Actions Inactive

alexott approved these changes Nov 22, 2024

View reviewed changes

feedback

0ad4294

nkvuong temporarily deployed to test-trigger-is November 26, 2024 09:54 — with GitHub Actions Inactive

fix test

8bdcda9

nkvuong temporarily deployed to test-trigger-is November 26, 2024 10:08 — with GitHub Actions Inactive

nkvuong temporarily deployed to test-trigger-is November 26, 2024 10:09 — with GitHub Actions Inactive

mgyucht reviewed Nov 26, 2024

View reviewed changes

feedback

2bac7aa

nkvuong temporarily deployed to test-trigger-is November 27, 2024 06:18 — with GitHub Actions Inactive

alexott requested a review from mgyucht November 27, 2024 11:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add `databricks_app` resource #4099

[Feature] Add `databricks_app` resource #4099

nkvuong commented Oct 12, 2024 •

edited

Loading

alexott left a comment

andrewnester Nov 14, 2024

andrewnester Nov 14, 2024

andrewnester commented Nov 21, 2024

nkvuong commented Nov 22, 2024

mgyucht left a comment

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

mgyucht Nov 26, 2024

github-actions bot commented Nov 27, 2024

eng-dev-ecosystem-bot commented Nov 27, 2024


		-> This feature is in [Public Preview](https://docs.databricks.com/release-notes/release-types.html).

		Apps run directly on a customer’s Databricks instance, integrate with their data, use and extend Databricks services, and enable users to interact through single sign-on.

[Feature] Add databricks_app resource #4099

Are you sure you want to change the base?

[Feature] Add databricks_app resource #4099

Conversation

nkvuong commented Oct 12, 2024 • edited Loading

Changes

Tests

alexott left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewnester commented Nov 21, 2024

nkvuong commented Nov 22, 2024

mgyucht left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024

eng-dev-ecosystem-bot commented Nov 27, 2024

[Feature] Add `databricks_app` resource #4099

[Feature] Add `databricks_app` resource #4099

nkvuong commented Oct 12, 2024 •

edited

Loading