[Internal] Set user agent in some resources implemented in plugin framework #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
requested review from
renaudhartert-db
and removed request for
a team
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
requested review from
rauchy and
mgyucht
and removed request for
renaudhartert-db
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
approved these changes
Nov 5, 2024
| "github.com/databricks/terraform-provider-databricks/internal/providers/pluginfw/converters" | ||
| "github.com/databricks/terraform-provider-databricks/internal/providers/pluginfw/tfschema" | ||
| "github.com/databricks/terraform-provider-databricks/internal/service/sharing_tf" | ||
| "github.com/hashicorp/terraform-plugin-framework/datasource" | ||
| "github.com/hashicorp/terraform-plugin-framework/datasource/schema" | ||
| ) | ||
|
|
||
| const dataSourceNameShare = "share" |
| @@ -120,15 +120,15 @@ We are migrating the resource from SDKv2 to Plugin Framework provider and hence | |||
|
|
|||
| ### Adding a new resource | |||
| 1. Check if the directory for this particular resource exists under `internal/providers/pluginfw/resources`, if not create the directory eg: `cluster`, `volume` etc... Please note: Resources and Data sources are organized under the same package for that service. | |||
| 2. Create a file with resource_resource-name.go and write the CRUD methods, schema for that resource. For reference, please take a look at existing resources eg: `resource_quality_monitor.go` | |||
| 2. Create a file with resource_resource-name.go and write the CRUD methods, schema for that resource. For reference, please take a look at existing resources eg: `resource_quality_monitor.go`. Make sure to set the user agent in all the CRUD methods. In the `Metadata()`, if the resource is to be used as default, use the method `GetDatabricksProductionName()` else use `GetDatabricksStagingName()` which suffixes the name with `_pluginframework`. | |||
There was a problem hiding this comment.
This might not be necessary if we decide to incorporate it into a core resource, which I'm currently working on implementing. Just a reminder to myself to update this part of the guidelines if we decide to go that route.
…ricks into share-upd
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…ricks into share-upd
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…ricks into share-upd
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11843045111 |
hectorcast-db
added a commit
that referenced
this pull request
Nov 20, 2024
### New Features and Improvements * Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source ([#3665](#3665)). * Add support partitions in policy data sources ([#4181](#4181)). * Added `databricks_registered_model_versions` data source ([#4100](#4100)). * Update databricks_permissions resource to support vector-search-endpoints ([#4209](#4209)). * add `databricks_serving_endpoints` data source ([#4226](#4226)). ### Bug Fixes * Add validation for `run_as_mode` in `databricks_query` ([#4233](#4233)). * Correct handling of updates for empty comments and `force_destroy` in UC catalog, schema, registered models and volumes ([#4244](#4244)). * Fix deletion of dashboard if it was trashed out of band ([#4235](#4235)). * Fix waiting for `databricks_vector_search_index` readiness ([#4243](#4243)). * Remove single-node validation from interactive clusters ([#4222](#4222)). * Remove single-node validation from jobs clusters ([#4216](#4216)). * Use cluster list API to determine pinned cluster status ([#4203](#4203)). * fix issue cased by setting pause_status in update monitor ([#4242](#4242)). ### Documentation * Clarify workspace provider config ([#4208](#4208)). * Update "Databricks Workspace Creator" permissions on gcp-workspace.md ([#4201](#4201)). * Update `grants.md` references ([#4246](#4246)). * Update description of `group_id` in `databricks_mws_ncc_private_endpoint_rule` ([#4238](#4238)). * remove subnet sharing limitation in AWS ([#4239](#4239)). ### Internal Changes * Bump Go SDK to latest and generate TF structs ([#4249](#4249)). * Mark TestUcAccModelServingProvisionedThroughput as flaky. to be rever… ([#4232](#4232)). * Rename resources directory to products in pluginframework ([#4139](#4139)). * Revert "mark TestUcAccModelServingProvisionedThroughput as flaky. to … ([#4240](#4240)). * Set user agent in some resources implemented in plugin framework ([#4187](#4187)). * make `ApplyAndExpectData` work with nested set ([#4237](#4237)). ### Dependency Updates * Bump dependencies for Plugin Framework and SDK v2 ([#4215](#4215)). * Bump github.com/hashicorp/hcl/v2 from 2.22.0 to 2.23.0 ([#4236](#4236)). * Bump github.com/hashicorp/terraform-plugin-testing from 1.10.0 to 1.11.0 ([#4247](#4247)). ### Exporter * Add `List` operation for `users` service ([#4204](#4204)). * Fix interactive selection of services ([#4245](#4245)).
hectorcast-db
added a commit
that referenced
this pull request
Nov 20, 2024
* Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source ([#3665](#3665)). * Add support partitions in policy data sources ([#4181](#4181)). * Added `databricks_registered_model_versions` data source ([#4100](#4100)). * Update databricks_permissions resource to support vector-search-endpoints ([#4209](#4209)). * add `databricks_serving_endpoints` data source ([#4226](#4226)). * Add validation for `run_as_mode` in `databricks_query` ([#4233](#4233)). * Correct handling of updates for empty comments and `force_destroy` in UC catalog, schema, registered models and volumes ([#4244](#4244)). * Fix deletion of dashboard if it was trashed out of band ([#4235](#4235)). * Fix waiting for `databricks_vector_search_index` readiness ([#4243](#4243)). * Remove single-node validation from interactive clusters ([#4222](#4222)). * Remove single-node validation from jobs clusters ([#4216](#4216)). * Use cluster list API to determine pinned cluster status ([#4203](#4203)). * fix issue cased by setting pause_status in update monitor ([#4242](#4242)). * Clarify workspace provider config ([#4208](#4208)). * Update "Databricks Workspace Creator" permissions on gcp-workspace.md ([#4201](#4201)). * Update `grants.md` references ([#4246](#4246)). * Update description of `group_id` in `databricks_mws_ncc_private_endpoint_rule` ([#4238](#4238)). * remove subnet sharing limitation in AWS ([#4239](#4239)). * Bump Go SDK to latest and generate TF structs ([#4249](#4249)). * Mark TestUcAccModelServingProvisionedThroughput as flaky. to be rever… ([#4232](#4232)). * Rename resources directory to products in pluginframework ([#4139](#4139)). * Revert "mark TestUcAccModelServingProvisionedThroughput as flaky. to … ([#4240](#4240)). * Set user agent in some resources implemented in plugin framework ([#4187](#4187)). * make `ApplyAndExpectData` work with nested set ([#4237](#4237)). * Bump dependencies for Plugin Framework and SDK v2 ([#4215](#4215)). * Bump github.com/hashicorp/hcl/v2 from 2.22.0 to 2.23.0 ([#4236](#4236)). * Bump github.com/hashicorp/terraform-plugin-testing from 1.10.0 to 1.11.0 ([#4247](#4247)). * Add `List` operation for `users` service ([#4204](#4204)). * Fix interactive selection of services ([#4245](#4245)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
### New Features and Improvements * Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source ([#3665](#3665)). * Add support partitions in policy data sources ([#4181](#4181)). * Added `databricks_registered_model_versions` data source ([#4100](#4100)). * Update databricks_permissions resource to support vector-search-endpoints ([#4209](#4209)). * add `databricks_serving_endpoints` data source ([#4226](#4226)). ### Bug Fixes * Add validation for `run_as_mode` in `databricks_query` ([#4233](#4233)). * Correct handling of updates for empty comments and `force_destroy` in UC catalog, schema, registered models and volumes ([#4244](#4244)). * Fix deletion of dashboard if it was trashed out of band ([#4235](#4235)). * Fix waiting for `databricks_vector_search_index` readiness ([#4243](#4243)). * Remove single-node validation from interactive clusters ([#4222](#4222)). * Remove single-node validation from jobs clusters ([#4216](#4216)). * Use cluster list API to determine pinned cluster status ([#4203](#4203)). * fix issue cased by setting pause_status in update monitor ([#4242](#4242)). ### Documentation * Clarify workspace provider config ([#4208](#4208)). * Update "Databricks Workspace Creator" permissions on gcp-workspace.md ([#4201](#4201)). * Update `grants.md` references ([#4246](#4246)). * Update description of `group_id` in `databricks_mws_ncc_private_endpoint_rule` ([#4238](#4238)). * remove subnet sharing limitation in AWS ([#4239](#4239)). ### Internal Changes * Bump Go SDK to latest and generate TF structs ([#4249](#4249)). * Mark TestUcAccModelServingProvisionedThroughput as flaky. to be rever… ([#4232](#4232)). * Rename resources directory to products in pluginframework ([#4139](#4139)). * Revert "mark TestUcAccModelServingProvisionedThroughput as flaky. to … ([#4240](#4240)). * Set user agent in some resources implemented in plugin framework ([#4187](#4187)). * make `ApplyAndExpectData` work with nested set ([#4237](#4237)). ### Dependency Updates * Bump dependencies for Plugin Framework and SDK v2 ([#4215](#4215)). * Bump github.com/hashicorp/hcl/v2 from 2.22.0 to 2.23.0 ([#4236](#4236)). * Bump github.com/hashicorp/terraform-plugin-testing from 1.10.0 to 1.11.0 ([#4247](#4247)). ### Exporter * Add `List` operation for `users` service ([#4204](#4204)). * Fix interactive selection of services ([#4245](#4245)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Following up for #4161 (comment), I noticed some other resources also aren't setting the user agent. Creating a PR to fix them. Also added a note in the contributing guideline.
Tests
NA
make testrun locallydocs/folderinternal/acceptance