Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add databricks_function resource #4189

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dgomez04
Copy link
Contributor

@dgomez04 dgomez04 commented Nov 2, 2024

Changes

Introduces databricks_function resource—allowing users to create and manage UDFs within Terraform. work in progress...

Closes #4074

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@dgomez04 dgomez04 requested review from a team as code owners November 2, 2024 02:35
@dgomez04 dgomez04 requested review from hectorcast-db and removed request for a team November 2, 2024 02:35
@dgomez04 dgomez04 changed the title [FEATURE] Add databricks_function resource [FEATURE] WIP Add databricks_function resource Nov 2, 2024
@dgomez04 dgomez04 changed the title [FEATURE] WIP Add databricks_function resource [Feature] [WIP] Add databricks_function resource Nov 2, 2024
@ian-norris-ncino
Copy link

Hello, is there any timeline on when this could make it into the provider? Would love to have this soon!

@dgomez04
Copy link
Contributor Author

dgomez04 commented Nov 4, 2024

Hi @ian-norris-ncino. I'm aiming to have this integrated into the provider by the end of the month, depending on my availability. I'll keep you posted.

Copy link

github-actions bot commented Nov 7, 2024

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4189
  • Commit SHA: f0b26224022f09addbe0dbc902911ad0e2501015

Checks will be approved automatically on success.

@dgomez04 dgomez04 changed the title [Feature] [WIP] Add databricks_function resource [Feature] Add databricks_function resource Nov 7, 2024
name = "calculate_bmi"
catalog_name = databricks_catalog.sandbox.name
schema_name = databricks_schema.functions.name
input_params = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be easier for people to specify input_param as separate blocks, like we do in other resources

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although doc says that input_params is a block, and then there are parameters inside: https://docs.databricks.com/api/workspace/functions/create#input_params

* `name` - (Required) The name of the parameter.
* `type` - (Required) The data type of the parameter (e.g., `DOUBLE`, `INT`, etc.).
* `data_type` - (Required) The return data type of the function (e.g., `DOUBLE`).
* `routine_body` - (Required) Specifies the body type of the function, either `SQL` for SQL-based functions or `EXTERNAL` for functions in external languages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see return_params

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11869831592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] New feature request: Create function
4 participants