Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add missing H2 header in mws_network_connectivity_configs.md and optimization in data_mws_network_connectivity_configs #4256

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Fix] Add missing H2 header in mws_network_connectivity_configs.md and optimization in data_mws_network_connectivity_configs #4256

merged 1 commit into from
Nov 21, 2024
+8 −4

Conversation

840
Copy link
Contributor

@840 840 commented Nov 20, 2024 •
edited
Loading

Changes

  • Add missing H2 header in mws_network_connectivity_configs.md
  • Remove unnecessary variable in data_mws_network_connectivity_configs

Tests

Ran integration test

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@840
Add missing H2 header in mws_network_connectivity_configs.md and sm…
6f22aa4 
…all optimization in `data_mws_network_connectivity_configs`
@840 840 requested review from a team as code owners November 20, 2024 16:07
@840 840 requested review from mgyucht and removed request for a team November 20, 2024 16:07
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4256
  • Commit SHA: 6f22aa4cf92621960949e70def808e4dcd5266fa

Checks will be approved automatically on success.

@840 840 enabled auto-merge November 20, 2024 17:31
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11949347015

@840 840 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into databricks:main with commit fabd319 Nov 21, 2024
14 checks passed
@840 840 deleted the ncc-improvements branch November 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht mgyucht is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@840 @eng-dev-ecosystem-bot @alexott