Updated intro message #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 92.51% 92.51%
=======================================
Files 9 9
Lines 681 681
Branches 110 110
=======================================
Hits 630 630
Misses 29 29
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
david-tempelmann
approved these changes
Sep 29, 2023
| @@ -61,10 +61,18 @@ def intro(self): | |||
| <h1>Hi there, I'm DiscoverX.</h1> | |||
|
|
|||
| <p> | |||
| I'm here to help you discover data in your lakehouse.<br /> | |||
| You can scan your lakehouse by using | |||
| I'm here to help you paralelize multi-table operations across your lakehouse.<br /> | |||
There was a problem hiding this comment.
typo: should be parallelize I think ...
| <ul> | ||
| <li><code>.apply_sql(...)</code> - Runs a SQL template on each table</li> | ||
| <li><code>.scan(...)</code> - Scan your lakehouse for columns matching the given rules</li> | ||
| <li><code>.search(...)</code> - Search your lakehouse for columns matching the given search term</li> |
There was a problem hiding this comment.
I was thinking a bit about the .search and if we should keep it here because this won't reflect the "new" api. But I guess it is fine and it will work the same way in the future when we plan to use tags. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.