Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #77

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Update docs #77

merged 5 commits into from
Oct 4, 2023

Conversation

edurdevic
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #77 (5a92b34) into master (b04defb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          11       11           
  Lines         791      791           
  Branches      132      132           
=======================================
  Hits          732      732           
  Misses         33       33           
  Partials       26       26           
Flag Coverage Δ
unittests 92.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
discoverx/dx.py 90.90% <ø> (ø)
discoverx/explorer.py 94.96% <100.00%> (ø)

Copy link
Contributor

@david-tempelmann david-tempelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Looks good otherwise

README.md Outdated
* `execute` executes the queries and shows the result in a unioned dataframe
* `to_union_dataframe` unions all the dataframes that result from the queries

* `display` executes the queries and shows the result in a unioned dataframe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display() would only output a limited number or rows correct? should we add that information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@edurdevic edurdevic merged commit 7c462df into master Oct 4, 2023
4 checks passed
@edurdevic edurdevic deleted the update-docs branch October 4, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants