-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #77
Update docs #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 11 11
Lines 791 791
Branches 132 132
=======================================
Hits 732 732
Misses 33 33
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. Looks good otherwise
README.md
Outdated
* `execute` executes the queries and shows the result in a unioned dataframe | ||
* `to_union_dataframe` unions all the dataframes that result from the queries | ||
|
||
* `display` executes the queries and shows the result in a unioned dataframe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display() would only output a limited number or rows correct? should we add that information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
No description provided.