Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 92 #94

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Issue 92 #94

merged 6 commits into from
Dec 27, 2023

Conversation

souravg-db
Copy link
Contributor

Added fix for dx.from_tables fails when hyphen exists in catalog or schema name

@souravg-db souravg-db requested a review from edurdevic December 21, 2023 23:33
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6169b97) 92.84% compared to head (7437f7b) 92.84%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          11       11           
  Lines         866      866           
  Branches      150      150           
=======================================
  Hits          804      804           
  Misses         34       34           
  Partials       28       28
Flag Coverage Δ
unittests 92.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edurdevic
edurdevic suggested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@edurdevic edurdevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all ([0-9a-zA-Z_\*]+) with ([0-9a-zA-Z_\*-]+) to enable - also in search patterns.

edurdevic
edurdevic approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@edurdevic edurdevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @souravg-db!

@edurdevic
Copy link
Contributor

This fixes #92

@edurdevic edurdevic merged commit 84007f0 into master Dec 27, 2023
5 checks passed
@edurdevic edurdevic deleted the issue-92 branch December 27, 2023 12:59
@souravg-db souravg-db mentioned this pull request Dec 27, 2023
Closed
@siddarthrokkam
Copy link

@souravg-db @edurdevic
When would this fix be available?

@souravg-db
Copy link
Contributor Author

@siddarthrokkam : Code changes are merged. We will release it soon.

@souravg-db
Copy link
Contributor Author

@siddarthrokkam : This is available in v0.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edurdevic edurdevic edurdevic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@souravg-db @edurdevic @siddarthrokkam @souravg-db2