Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required notebook #97

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Added required notebook #97

merged 3 commits into from
Jan 8, 2024

Conversation

souravg-db
Copy link
Contributor

No description provided.

@souravg-db souravg-db requested a review from edurdevic January 2, 2024 14:06
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ddf061a) 92.90% compared to head (24113e9) 92.90%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files          11       11           
  Lines         874      874           
  Branches      151      151           
=======================================
  Hits          812      812           
  Misses         34       34           
  Partials       28       28           
Flag Coverage Δ
unittests 92.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@edurdevic edurdevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating the owner twice now.
Please remove one of the two triggers

examples/update_owner_of_data_objects.py Outdated Show resolved Hide resolved
Copy link
Contributor

@edurdevic edurdevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edurdevic edurdevic merged commit dfc9c3f into master Jan 8, 2024
5 checks passed
@edurdevic edurdevic deleted the example_notebook_update_owner branch January 8, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants