Skip to content

Commit

Permalink
Maintain PySpark compatibility for databricks.labs.lsql.core.Row (#99)
Browse files Browse the repository at this point in the history
Add asDict to databricks.labs.lsql.core.Row to maintain PySpark
compatibility
  • Loading branch information
bishwajit-db authored May 8, 2024
1 parent 1664d17 commit 2245043
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/databricks/labs/lsql/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def fetch(self, sql: str, *, catalog: str | None = None, schema: str | None = No
self._spark.sql(f"USE CATALOG {catalog}")
if schema:
self._spark.sql(f"USE SCHEMA {schema}")
# TODO: pyspark.sql.Row is being returned instead of databricks.labs.lsql.core.Row
return iter(self._spark.sql(sql).collect())
except Exception as e:
error_message = str(e)
Expand Down
4 changes: 4 additions & 0 deletions src/databricks/labs/lsql/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ def as_dict(self) -> dict[str, Any]:
"""Convert the row to a dictionary with the same conventions as Databricks SDK."""
return dict(zip(self.__columns__, self, strict=True))

# PySpark's compatibility
def asDict(self, recursive: bool = False) -> dict[str, Any]:
return self.as_dict()

def __eq__(self, other):
"""Check if the rows are equal."""
if not isinstance(other, Row):
Expand Down

0 comments on commit 2245043

Please sign in to comment.