Add multi select filter #174
Conversation
There was a problem hiding this comment.
@nfx : The filter needs some rethinking as in Lakeview this is another widget (not part of the the table). Filters can actually operate on multiple widgets if they use the same dataset, but we create a dataset and widget per query, so there would be a one-to-one relationship in our case.
| widget = Widget(name=f"{self._widget_metadata.id}_filter", queries=[named_query], spec=spec) | ||
| return widget | ||
|
|
||
| def _get_named_query(self, fields: list[Field], *, name: str = "main_query", disaggregated: bool = True) -> NamedQuery: |
There was a problem hiding this comment.
Does not really do much anymore besides passing parameters
| layout = Layout(widget=tile.widget, position=tile.position) | ||
| layouts.append(layout) | ||
| if isinstance(tile, QueryTile) and tile.filter is not None: | ||
| layout = Layout(widget=tile.filter, position=tile.position) |
There was a problem hiding this comment.
Need to figure out what to do with the filter position
| @@ -377,6 +410,9 @@ def _get_layouts(widgets_metadata: list[WidgetMetadata]) -> list[Layout]: | |||
| placed_tile = tile.place_after(position) | |||
| layout = Layout(widget=placed_tile.widget, position=placed_tile.position) | |||
There was a problem hiding this comment.
@nfx : Maybe we want to convert the widget on a tile to widgets. Might be useful in future cases, or at least for multiple filters (on different columns)
| @@ -81,16 +83,18 @@ def __init__( | |||
| width: int = 0, | |||
| height: int = 0, | |||
There was a problem hiding this comment.
WidgetMetdata is not becoming accurate anymore. It would be TileMetadata
JCZuurmond
force-pushed
the
feat/add-multi-select-filter
branch
from
68f524d to
d4946b7
Compare
|
Preferences goes to #181 |
Resolves #169
Stacked on #150