Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle API call failure in cluster-events #1285

Open
wants to merge 2 commits into
base: 0820_release
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see this comment on the PR.

Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,11 @@ trait BronzeTransforms extends SparkSessionWrapper {
logger.log(Level.INFO, "COMPLETE: Cluster Events acquisition, building data")
if (Helpers.pathExists(tmpClusterEventsSuccessPath)) {
val baseDF = spark.read.json(tmpClusterEventsSuccessPath)
if (baseDF.isEmpty) {
logger.info("EMPTY MODULE: Cluster Events")
throw new NoNewDataException(s"EMPTY: No New Cluster Events. Progressing module but it's recommended you " +
s"validate there no api call errors in ${erroredBronzeEventsTarget.tableFullName}", Level.WARN, allowModuleProgression = true)
}
val rawDf = deriveRawApiResponseDF(baseDF)
if (rawDf.columns.contains("events")) {
try {
Expand Down