-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lcp to v0.2.10 #8
Changes from 4 commits
6482de3
5d72846
1bc9bbc
fa22ffa
70106c3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# cargo-machete v0.7.0 detects unused dependencies in lcp. | ||
# Thus ignore linting for submodules until resolved the issue. | ||
# --- | ||
# Analyzing dependencies of crates in this directory... | ||
# cargo-machete found the following unused dependencies in this directory: | ||
# light-client -- ./e2e/lcp/modules/light-client/Cargo.toml: | ||
# serde | ||
lcp/ | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
######## Import SGX SDK ######## | ||
include ImportRustSGXSDK.mk | ||
|
||
######## SGX SDK Settings ######## | ||
SGX_SDK ?= /opt/sgxsdk | ||
SGX_MODE ?= HW | ||
|
@@ -9,7 +6,7 @@ SGX_DEBUG ?= 0 | |
SGX_PRERELEASE ?= 0 | ||
SGX_PRODUCTION ?= 0 | ||
|
||
include rust-sgx-sdk/buildenv.mk | ||
include buildenv.mk | ||
|
||
ifeq ($(shell getconf LONG_BIT), 32) | ||
SGX_ARCH := x86 | ||
|
@@ -52,27 +49,20 @@ endif | |
|
||
SGX_COMMON_CFLAGS += -fstack-protector | ||
|
||
CARGO_FEATURES = --features=default | ||
ifeq ($(SGX_PRODUCTION), 1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @junichi-tanaka Can you also remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
SGX_ENCLAVE_MODE = "Production Mode" | ||
SGX_ENCLAVE_CONFIG = $(SGX_ENCLAVE_CONFIG) | ||
SGX_SIGN_KEY = $(SGX_COMMERCIAL_KEY) | ||
CARGO_FEATURES = --features=production | ||
else | ||
SGX_ENCLAVE_MODE = "Development Mode" | ||
SGX_ENCLAVE_CONFIG = "enclave/Enclave.config.xml" | ||
SGX_SIGN_KEY = "enclave/Enclave_private.pem" | ||
ifneq ($(SGX_MODE), HW) | ||
CARGO_FEATURES = --features=default,sgx-sw | ||
endif | ||
endif | ||
|
||
######## CUSTOM Settings ######## | ||
|
||
CUSTOM_LIBRARY_PATH := ./lib | ||
CUSTOM_BIN_PATH := ./bin | ||
CUSTOM_EDL_PATH := ./rust-sgx-sdk/edl | ||
CUSTOM_COMMON_PATH := ./rust-sgx-sdk/common | ||
|
||
######## EDL Settings ######## | ||
|
||
|
@@ -93,7 +83,7 @@ ProtectedFs_Library_Name := sgx_tprotected_fs | |
|
||
RustEnclave_C_Files := $(wildcard ./enclave/*.c) | ||
RustEnclave_C_Objects := $(RustEnclave_C_Files:.c=.o) | ||
RustEnclave_Include_Paths := -I$(CUSTOM_COMMON_PATH)/inc -I$(CUSTOM_EDL_PATH) -I$(SGX_SDK)/include -I$(SGX_SDK)/include/tlibc -I$(SGX_SDK)/include/stlport -I$(SGX_SDK)/include/epid -I ./enclave -I./include | ||
RustEnclave_Include_Paths := -I$(SGX_SDK)/include -I$(SGX_SDK)/include/tlibc -I$(SGX_SDK)/include/stlport -I$(SGX_SDK)/include/epid -I ./enclave -I./include | ||
|
||
RustEnclave_Link_Libs := -L$(CUSTOM_LIBRARY_PATH) -lenclave | ||
RustEnclave_Compile_Flags := $(SGX_COMMON_CFLAGS) $(ENCLAVE_CFLAGS) $(RustEnclave_Include_Paths) | ||
|
@@ -110,7 +100,7 @@ Signed_RustEnclave_Name := bin/enclave.signed.so | |
######## EDL Objects ######## | ||
|
||
$(Enclave_EDL_Files): $(SGX_EDGER8R) enclave/Enclave.edl | ||
$(SGX_EDGER8R) --trusted enclave/Enclave.edl --search-path $(SGX_SDK)/include --search-path $(CUSTOM_EDL_PATH) --trusted-dir enclave | ||
$(SGX_EDGER8R) --trusted enclave/Enclave.edl --search-path $(SGX_SDK)/include --trusted-dir enclave | ||
@echo "GEN => $(Enclave_EDL_Files)" | ||
|
||
######## Enclave Objects ######## | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize this. In cases where the
ibc
feature is not enabled,serde
may not be necessary.