Adding Case Studies of India Data #229
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
|
||
| - [Analyzing the relation between Fertility Rate and the Number of Vasectomies and Tubectomies](https://colab.research.google.com/drive/1_heEp-E6dEMJoJmlbKu5avb2R2WdJnGI){:target="_blank"} | ||
|
|
||
| - [Analyzing Relation Between Unemployment Rate and Rural/Urban Population](https://colab.research.google.com/drive/1mC8jmkOUwstTU6ySB0Oo9lOFDOyra-1f){:target="_blank"} |
There was a problem hiding this comment.
See my comments on a copy of this colab here: https://colab.research.google.com/drive/1-03jimohY9e_-omFgRW8M31wI58ToJb4?usp=sharing
|
|
||
| - [Analyzing Earthquake Magnitude Levels of India](https://colab.research.google.com/drive/15EPTLU3bKyf95av87xHUMKzXL_WehtNA){:target="_blank"} | ||
|
|
||
| - [Analyzing the relation between Fertility Rate and the Number of Vasectomies and Tubectomies](https://colab.research.google.com/drive/1_heEp-E6dEMJoJmlbKu5avb2R2WdJnGI){:target="_blank"} |
There was a problem hiding this comment.
See my comments on a copy of this colab here: https://colab.research.google.com/drive/19xUhJmhFuOAsA-nuULC_Xc3v4j-RW9FX?usp=sharing
Most important: One of the plots is broken (shows up as blank axes)
|
|
||
| - [Analyzing the Relation between Fertility Rate along with Life Expectancy and Infant Mortality Rate](https://colab.research.google.com/drive/1rYjWjeZFU6b2lvaNvs9hKTfx75d4_r7i){:target="_blank"} | ||
|
|
||
| - [Analyzing Earthquake Magnitude Levels of India](https://colab.research.google.com/drive/15EPTLU3bKyf95av87xHUMKzXL_WehtNA){:target="_blank"} |
There was a problem hiding this comment.
See my comments on a copy of this colab here: https://colab.research.google.com/drive/1ZBMN6n0nI9F14tiS6VeBd5xbtacxJCx-?usp=sharing
|
|
||
| - [State-wise Infant Heath Analysis](https://colab.research.google.com/drive/1hiDoxB46QR8ZoV5yEm4WIFfNF8E-jDbs#scrollTo=BG_H4WFiKj5B){:target="_blank"} | ||
|
|
||
| - [Analyzing the Relation between Fertility Rate along with Life Expectancy and Infant Mortality Rate](https://colab.research.google.com/drive/1rYjWjeZFU6b2lvaNvs9hKTfx75d4_r7i){:target="_blank"} |
There was a problem hiding this comment.
See my comments on a copy of this colab here: https://colab.research.google.com/drive/1mGBkSVq5vjxndCo1p3H51tPsssc4Alem?usp=sharing
| ### India | ||
| - [Analysis of Mean Daily Wages of Men and Women of India](https://colab.research.google.com/drive/1oL0v6ZB4InHnMYo3bTQcSs4ZIHz6XIQ7#scrollTo=GE0b7K-Tiq8p){:target="_blank"} | ||
|
|
||
| - [State-wise Infant Heath Analysis](https://colab.research.google.com/drive/1hiDoxB46QR8ZoV5yEm4WIFfNF8E-jDbs#scrollTo=BG_H4WFiKj5B){:target="_blank"} |
There was a problem hiding this comment.
See my comments on a copy of this colab here: ]https://colab.research.google.com/drive/13C9qWyy16gpW3mBu0T-FcDU_sqaT5eNS?usp=sharing
|
|
||
|
|
||
| ### India | ||
| - [Analysis of Mean Daily Wages of Men and Women of India](https://colab.research.google.com/drive/1oL0v6ZB4InHnMYo3bTQcSs4ZIHz6XIQ7#scrollTo=GE0b7K-Tiq8p){:target="_blank"} |
There was a problem hiding this comment.
See my comments on a copy of this colab here:https://colab.research.google.com/drive/1za7WMutuAJT4JdhVmn2CviQ4yJVGm-1p?usp=sharing
Most importantly, there's a section that's broken because you reference a local .csv file
There was a problem hiding this comment.
Congrats on your first PR! These are some interesting analyses!
Some general comments:
-
Standardize the titles and .ipynb filenames of the colabs
- use the same capitalization rules
- Mention India in the titles and filenames
-
Run your prose through a spell checker, check capitalization
-
Edit your code cells to adhere to the PEP8 style guide (see https://peps.python.org/pep-0008/)
- Make sure line lengths never exceed 80 characters
- Use a consistent comment style (capitalization, space after a '#' character)
- Use PEP257 docstrings for your functions (see https://peps.python.org/pep-0257/)
- My suggestion is to use a linter or formatter that can auto-highlight / auto-fix these for you
-
Follow best practices for all figures
- Make sure every graph has a descriptive title, and axes are labeled
- Make the font size for all figures bigger so that they are legible without needing to zoom in
-
Add links to sources
- link any references you used to write the introductory paragraphs
-
Cite your assertions
- In the paragraphs you add explaining graphs, sometimes you have assertions that are possible explanations for what is seen in the graphs, but not supported by the data directly. You must add a source for each of these assertions, or make it very clear the statement is merely a hypothesis for explaining the data.
Good work so far. Looking forward to seeing the edits! Let me know if you can't access the colab links.
Providing case studies for India data will help gain a better understanding of various subjects and issues of India. This will help in providing solutions to problems and coming up with concrete plans to solve them.