Rewrite intro section of custom data #546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyurva
reviewed
Nov 21, 2024
| | San Jose | 2023 | private | middle | 200 | | ||
| | San Jose | 2023 | private | secondary | 100 | | ||
|
|
||
| Although the properties of school type and school level may already be defined in the Data Commons knowledge graph (or you may need to define them), they _cannot_ be present as columns in the CSV files that you store in Data Commons. Instead, you must create separate "count" variables to represent each case. In our example, you would actually need 6 different variables: |
There was a problem hiding this comment.
Can we caveat this by saying that the schema allows for it (same variable with different observation properties) but with simple CSV formats for custom dcs they should define separate variables.
There was a problem hiding this comment.
Let's leave it for now; I will include with the rewrite for variable-per-row.
dwnoble
reviewed
Nov 25, 2024
…nto custom_dc_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the full-on variable per row coverage, I found some egregiously incorrect statements, so doing an incremental update here. (Also cleaning up some TOC levels.)