Update redirect criteria so that the shouldSkipPlaceOverview functi…

…on is only called once, and it is only called in a context where we are sure that the pageMetaData exists.
datacommonsorg · Nov 15, 2024 · c93718d · c93718d
1 parent 4387d55
commit c93718d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/static/js/apps/explore/app.tsx b/static/js/apps/explore/app.tsx
@@ -211,12 +211,14 @@ export function App(props: { isDemo: boolean }): JSX.Element {
       sessionId: "session" in fulfillData ? fulfillData["session"]["id"] : "",
       svSource: fulfillData["svSource"],
     };
+    let isPendingRedirect = false;
     if (
       pageMetadata &&
       pageMetadata.pageConfig &&
       pageMetadata.pageConfig.categories
     ) {
-      if (shouldSkipPlaceOverview(pageMetadata)) {
+      isPendingRedirect = shouldSkipPlaceOverview(pageMetadata);
+      if (isPendingRedirect) {
         const placeDcid = pageMetadata.place.dcid;
         const url = `/place/${placeDcid}`;
         window.location.replace(url);
@@ -263,9 +265,7 @@ export function App(props: { isDemo: boolean }): JSX.Element {
       sessionId: pageMetadata.sessionId,
     });
     setLoadingStatus(
-      shouldSkipPlaceOverview(pageMetadata)
-        ? LoadingStatus.LOADING
-        : LoadingStatus.SUCCESS
+      isPendingRedirect ? LoadingStatus.LOADING : LoadingStatus.SUCCESS
     );
   }