Fix custom DC tests (NL goldens, shared tests) #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some CSS selectors specifically for tests to use - Run all webdriver tests with `-n auto` to maybe speed them up - Add option to run_cdc_tests for regenerating goldens
dwnoble
approved these changes
Nov 15, 2024
gmechali
pushed a commit
to gmechali/website
that referenced
this pull request
Nov 21, 2024
- In one file, don't reference h1 by a selector only present in main DC - In another file, add some CSS selectors specifically for tests to use - Add option to run_cdc_tests for regenerating goldens To prevent failures from recurring, we should make custom DC tests run before merge instead of just after autopush.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent failures from recurring, we should make custom DC tests run before merge instead of just after autopush.