Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datafold Public Demo #97

Closed
wants to merge 3 commits into from
Closed

Datafold Public Demo #97

wants to merge 3 commits into from

Conversation

sungchun12
Copy link
Contributor

@sungchun12 sungchun12 commented Sep 24, 2023

This is what Datafold CI looks and feels like!

Book a Live Demo

Code Changes

  1. Update logic of dim_orgs.created_at
    • The dim_orgs model is built around the first user sign_up event, but I noticed we have an org_created event that might make more sense to use.
    • Seems very likely that there could be a big time difference between an org creation and the first user signing in, or an org never having a user sign in.
    • So, we're swapping sign_up events for org_created events in model dim_orgs
  2. Set dim_orgs.sub_price to 0 when the value would be null.
  3. Recategorize dim_orgs.sub_plan to Individual when num_users is 1
  4. Include Individual opportunities in the Sales Sync.

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
master (1986a36) demos/sung (3cf4d11)
 Data Diffs of tables modified in this pull request: 2
DEMO.CORE.DIM_ORGS
Primary keys ORG_ID
master demos/sung
DIFFERENCES
  Total rows 157 146 -7.0%
  Exclusive PKs 11 0
 2 column(s) with differing values
column number of rows
CREATED_AT 112  76.7%
SUB_PLAN 94  64.4%
 
NO DIFFERENCES
Total columns 6
Schema changes 0
Common unique PKs 146
Rows with NULL PKs 0
Rows with duplicate PKs 0
 
Data app dependencies
 looker — 4
 hightouch — 1
View details →



DEMO.CORE.SALES_SYNC
Primary keys ORG_ID
master demos/sung
DIFFERENCES
  Total rows 4 3 -25.0%
  Exclusive PKs 2 1
 
NO DIFFERENCES
Total columns 2
Schema changes 0
Common unique PKs 2
Rows with NULL PKs 0
Rows with duplicate PKs 0
Columns with different values 0
 
Data app dependencies
 hightouch — 1
View details →
Skipped Data Diffs of downstream tables: 2 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
DEMO.CORE.fct_monthly_financials (table) Run Data Diff →
DEMO.CORE.fct_yearly_financials (table) Run Data Diff →

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
master (1986a36) demos/sung (3cf4d11)
 Data Diffs of tables modified in this pull request: 2
DEMO.CORE.DIM_ORGS
Primary keys ORG_ID
master demos/sung
DIFFERENCES
  Total rows 157 146 -7.0%
  Exclusive PKs 11 0
 2 column(s) with differing values
column number of rows
CREATED_AT 112  76.7%
SUB_PLAN 94  64.4%
 
NO DIFFERENCES
Total columns 6
Schema changes 0
Common unique PKs 146
Rows with NULL PKs 0
Rows with duplicate PKs 0
 
Data app dependencies
 looker — 4
 hightouch — 1
View details →



DEMO.CORE.SALES_SYNC
Primary keys ORG_ID
master demos/sung
DIFFERENCES
  Total rows 4 3 -25.0%
  Exclusive PKs 2 1
 
NO DIFFERENCES
Total columns 2
Schema changes 0
Common unique PKs 2
Rows with NULL PKs 0
Rows with duplicate PKs 0
Columns with different values 0
 
Data app dependencies
 hightouch — 1
View details →
 Data Diffs of downstream tables: 2
DEMO.CORE.FCT_MONTHLY_FINANCIALS
Primary keys DATE_MONTH
master demos/sung
DIFFERENCES
  Total rows 6 5 -16.7%
  Exclusive PKs 1 0
 2 column(s) with differing values
column number of rows
SUM_REVENUE 1  20.0%
CNT_SUBSCRIBERS 1  20.0%
 
NO DIFFERENCES
Total columns 3
Schema changes 0
Common unique PKs 5
Rows with NULL PKs 0
Rows with duplicate PKs 0
 
 Modified upstream models   model.demo.dim_orgs
Data app dependencies
 looker — 4
View details →



DEMO.CORE.FCT_YEARLY_FINANCIALS
Primary keys DATE_YEAR
DIFFERENCES
 2 column(s) with differing values
column number of rows
YEARLY_REVENUE 1  100.0%
YEARLY_SUBSCRIBERS 1  100.0%
 
NO DIFFERENCES
Total rows 1
Total columns 3
Schema changes 0
Common unique PKs 1
Added/removed rows 0
Rows with NULL PKs 0
Rows with duplicate PKs 0
 
 Modified upstream models   model.demo.dim_orgs
View details →

@sungchun12 sungchun12 changed the title Demos/sung Demo by Sung Sep 24, 2023
@sungchun12 sungchun12 changed the title Demo by Sung Datafold Demo by Sung Sep 24, 2023
@sungchun12
Copy link
Contributor Author

sungchun12 commented Sep 24, 2023

Full column level lineage impact based on database query history when you click the links!

image

image

@sungchun12 sungchun12 changed the title Datafold Demo by Sung Datafold Public Demo Sep 24, 2023
@sungchun12 sungchun12 added the demo demo PR to show features label Sep 24, 2023
@leoebfolsom leoebfolsom deleted the demos/sung branch April 26, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafold:diff-all-downstream demo demo PR to show features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants