Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shrimpo models/tables #204

Merged
merged 44 commits into from
Mar 14, 2024
Merged

add shrimpo models/tables #204

merged 44 commits into from
Mar 14, 2024

Conversation

mcfiredrill
Copy link
Member

No description provided.

@mcfiredrill mcfiredrill marked this pull request as draft December 28, 2022 20:04
@mcfiredrill mcfiredrill marked this pull request as ready for review March 11, 2024 03:13
@mcfiredrill mcfiredrill requested a review from dudethatbe March 11, 2024 03:23
@@ -15,6 +15,7 @@ class ExperiencePointAward < ApplicationRecord
:streamingatron, # streaming live
:glorppy, # daily glorp lottery
:gloppy, # daily glop lottery
:shrimpo_prize, # winning shrimpo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it seems a little repetitive to say shrimpo_prize when its already a shrimp. There's only one winner per shrimpo right? maybe it can be :first_prize, :trophy_winner, or whatever??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the thing is this is used directly in the notification text:

  when "experience_point_award"
      "You got #{self.source.amount} #{self.source.award_type} points!"`

So I was wondering if "You got 500 shrimpo prize points!" would sound ok or if we should change it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case maybe just 'shrimpo' is fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that message would make the most sense for now 🦐

after_create :queue_end_shrimpo_job

VALID_DURATIONS = [
# minors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entries to a minor shrimpo are anonymized until the shrimpo is over

entries to a major shrimpo are public even before the voting starts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow ok didn't even think about that but it makes sense to me. how does one choose one type over the other?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,2 @@
class ShrimpoVotingCategory < ApplicationRecord
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this or maybe we'll use it later IDK yet

@@ -0,0 +1,12 @@
class CreateShrimpoVotingCategories < ActiveRecord::Migration[7.0]
def change
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this table or maybe we'll use later IDK yet

@mcfiredrill mcfiredrill merged commit 1b8aa7a into main Mar 14, 2024
2 checks passed
@mcfiredrill mcfiredrill deleted the shrimpo branch March 14, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants