Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Sentry issue when check is not found #211

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bolinocroustibat
Copy link
Contributor

@bolinocroustibat bolinocroustibat commented Oct 30, 2024

Handle Sentry issue #148024 with at least more explicit error reporting.

Should we just log a warning for that?

PR can be improved depending on what we decide.

@bolinocroustibat bolinocroustibat self-assigned this Oct 30, 2024
@bolinocroustibat bolinocroustibat changed the title fix: fix sentry issue 148024 fix: handle Sentry issue #148024 Oct 30, 2024
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused of when this would happen though

@bolinocroustibat
Copy link
Contributor Author

I am confused of when this would happen though

Me too, but it seems it does happen, for some reason. Some race condition maybe?

@bolinocroustibat bolinocroustibat changed the title fix: handle Sentry issue #148024 fix: handle Sentry issue when check is not found Nov 15, 2024
@bolinocroustibat bolinocroustibat marked this pull request as draft November 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants