Skip to content

Commit

Permalink
fix(ingest/lookml): emit warnings for resolution failures
Browse files Browse the repository at this point in the history
In most cases, these indicate minor syntax errors. Now that we have a
warning state, it's more appropriate than failure.
  • Loading branch information
hsheth2 committed Dec 23, 2024
1 parent b6ea974 commit df60ca6
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,13 @@ def resolve_includes(
f"traversal_path={traversal_path}, included_files = {included_files}, seen_so_far: {seen_so_far}"
)
if "*" not in inc and not included_files:
reporter.report_failure(
reporter.warning(

Check warning on line 189 in metadata-ingestion/src/datahub/ingestion/source/looker/looker_dataclasses.py

View check run for this annotation

Codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/looker/looker_dataclasses.py#L189

Added line #L189 was not covered by tests
title="Error Resolving Include",
message=f"Cannot resolve include {inc}",
context=f"Path: {path}",
)
elif not included_files:
reporter.report_failure(
reporter.warning(

Check warning on line 195 in metadata-ingestion/src/datahub/ingestion/source/looker/looker_dataclasses.py

View check run for this annotation

Codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/looker/looker_dataclasses.py#L195

Added line #L195 was not covered by tests
title="Error Resolving Include",
message=f"Did not resolve anything for wildcard include {inc}",
context=f"Path: {path}",
Expand Down

0 comments on commit df60ca6

Please sign in to comment.