Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): always resolve platform for browse path v2 #12045

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(ingest): always resolve platform for browse path v2 #12045

merged 2 commits into from
Dec 12, 2024

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 5, 2024
@mayurinehate mayurinehate force-pushed the fix_platform_instance_browse_path_v2 branch from 801f047 to 73c38bc Compare December 11, 2024 12:49
@mayurinehate mayurinehate marked this pull request as ready for review December 11, 2024 12:53
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 11, 2024
hsheth2
hsheth2 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What bug came up that caused us to need this?

metadata-ingestion/src/datahub/ingestion/api/source.py
getattr(config, "platform_name", None)
or getattr(self, "platform", None)
or getattr(config, "platform", None)
)
if platform is None and hasattr(self, "get_platform_id"):
platform = type(self).get_platform_id()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_platform_id comes from the decorators, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This was observed for dremio that platform_instance entry was not getting added in browse path v2.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 11, 2024
@mayurinehate mayurinehate merged commit 3ae82f6 into datahub-project:master Dec 12, 2024
73 checks passed
@mayurinehate mayurinehate mentioned this pull request Dec 12, 2024
Merged
5 tasks
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@mayurinehate @sleeperdeep
fix(ingest): always resolve platform for browse path v2 (datahub-proj…
dccd251 
…ect#12045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @hsheth2