Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ownership from Preset #12154

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Ownership from Preset #12154

wants to merge 6 commits into from

Conversation

enosodigie
Copy link

This feature syncs in Dataset, Chart, Dashboard owners listed on Preset into Datahub.

Screenshot of a Dataset with owners:
Screenshot 2024-11-19 at 9 41 01 AM

Screenshot of a Chart with owners:
Screenshot 2024-11-19 at 9 42 21 AM

Screenshot of a Dashboard with owners:
Screenshot 2024-11-19 at 9 45 04 AM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 17, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 17, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 18, 2024
sgomezvillamor
sgomezvillamor requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, contrib looks pretty good! Thanks for the effort!

Beyond some minor suggestions, may you add some tests? You may want to extend the existing ones in https://github.com/datahub-project/datahub/tree/master/metadata-ingestion/tests/integration/superset and https://github.com/datahub-project/datahub/tree/master/metadata-ingestion/tests/integration/preset

metadata-ingestion/src/datahub/ingestion/source/superset.py Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 18, 2024
sgomezvillamor
sgomezvillamor requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! With a some testing, it should be ready to merge.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enosodigie @sgomezvillamor @llance