feat(api): authorization extended for soft-delete and suspend #12158

david-leifker · 2024-12-18T05:15:13Z

feat(api): authorization extended for soft-delete and suspended

Key Aspects Always Returned
- Fix AspectRetriever behavior with respect to key aspects always returned
- Legacy use of the EntityClient and restli will by default continue to return key aspects regardless for backwards compatibility
Deprecated active boolean flag in corpUserInfo not supported
Fix Global exception handler
Add CachingAspectRetriever to OperationContext
Increase corp user aspect caching to 5 min (corpUserKey, status, corpUserStatus)

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

* fix AspectRetriever behavior with respect to key aspects always returned * Deprecated active boolean in corpUserInfo not supported

david-leifker · 2024-12-18T16:25:36Z

metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java

@@ -22,7 +22,7 @@

 @Getter
 @Builder
-public class EntityServiceAspectRetriever implements CachingAspectRetriever {
+public class EntityServiceAspectRetriever implements AspectRetriever {


This impl is not caching, corrected interface.

david-leifker · 2024-12-18T16:27:18Z

metadata-operation-context/src/main/java/io/datahubproject/metadata/context/ActorContext.java

+   * @param aspectRetriever aspect retriever - ideally the SystemEntityClient backed one for caching
+   * @return active status
+   */
+  public boolean isActive(AspectRetriever aspectRetriever) {


Primary logic for evaluation of the actor's state.

david-leifker · 2024-12-18T16:27:57Z

...ata-operation-context/src/main/java/io/datahubproject/metadata/context/OperationContext.java

@@ -177,7 +209,7 @@ public static OperationContext asSystem(
  @Nonnull private final EntityRegistryContext entityRegistryContext;
  @Nullable private final ServicesRegistryContext servicesRegistryContext;
  @Nullable private final RequestContext requestContext;
-  @Nullable private final RetrieverContext retrieverContext;
+  @Nonnull private final RetrieverContext retrieverContext;


Due to the importance of this context for actor state validation, it is no longer optional.

RyanHolstien · 2024-12-18T16:28:27Z

...stli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityV2Resource.java

@@ -90,7 +91,7 @@ public Task<EntityResponse> get(
                  ? opContext.getEntityAspectNames(entityName)
                  : new HashSet<>(Arrays.asList(aspectNames));
          try {
-            return _entityService.getEntityV2(opContext, entityName, urn, projectedAspects);
+            return _entityService.getEntityV2(opContext, entityName, urn, projectedAspects, alwaysIncludeKeyAspect == null || alwaysIncludeKeyAspect);


Rest.li does have default values, but this works too 😄

david-leifker · 2024-12-18T16:28:59Z

metadata-service/configuration/src/main/resources/application.yaml

@@ -522,12 +522,12 @@ cache:
      entityAspectTTLSeconds:
        # cache user aspects for 20s
        corpuser:


Effects the CachingAspectRetriever

david-leifker · 2024-12-18T16:29:21Z

...servlet/src/main/java/io/datahubproject/openapi/config/GlobalControllerExceptionHandler.java

@@ -1,9 +1,11 @@
-package io.datahubproject.openapi;
+package io.datahubproject.openapi.config;


Important relocation here, previously it was not being picked up.

david-leifker · 2024-12-18T16:29:45Z

...ce/openapi-servlet/src/main/java/io/datahubproject/openapi/operations/test/IdController.java

@@ -0,0 +1,54 @@
+package io.datahubproject.openapi.operations.test;


Added this for smoke-test

david-leifker · 2024-12-18T16:30:09Z

smoke-test/tests/tokens/revokable_access_token_test.py

@@ -490,45 +492,3 @@ def getAccessTokenMetadata(session, token):
    response.raise_for_status()

    return response.json()
-


Move to common util

david-leifker · 2024-12-18T16:30:29Z

smoke-test/tests/tokens/session_access_token_test.py

@@ -0,0 +1,173 @@
+import os


Primary test case for the feat.

github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Dec 18, 2024

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 18, 2024

david-leifker force-pushed the base-authorization-check branch from 8b74c9d to 45f00d5 Compare December 18, 2024 05:24

vercel bot deployed to Preview December 18, 2024 05:51 View deployment

david-leifker force-pushed the base-authorization-check branch from 45f00d5 to 6d03e03 Compare December 18, 2024 16:08

feat(api): authorization extended for soft-delete and suspended

441003b

* fix AspectRetriever behavior with respect to key aspects always returned * Deprecated active boolean in corpUserInfo not supported

david-leifker force-pushed the base-authorization-check branch from 6d03e03 to 441003b Compare December 18, 2024 16:16

david-leifker commented Dec 18, 2024

View reviewed changes

RyanHolstien reviewed Dec 18, 2024

View reviewed changes

david-leifker commented Dec 18, 2024

View reviewed changes

smoke-test/tests/tokens/session_access_token_test.py

@@ -0,0 +1,173 @@

import os

Copy link

Collaborator Author

david-leifker Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary test case for the feat.

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 18, 2024

vercel bot deployed to Preview December 18, 2024 16:44 View deployment

RyanHolstien approved these changes Dec 18, 2024

View reviewed changes

datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 18, 2024

david-leifker merged commit 8c724db into datahub-project:master Dec 18, 2024
99 of 105 checks passed

kevinkarchacryl mentioned this pull request Dec 19, 2024

fix(graphql): add suspended to corpuserstatus #12185

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(api): authorization extended for soft-delete and suspend #12158

feat(api): authorization extended for soft-delete and suspend #12158

david-leifker commented Dec 18, 2024 •

edited

Loading

david-leifker Dec 18, 2024

david-leifker Dec 18, 2024

david-leifker Dec 18, 2024 •

edited

Loading

RyanHolstien Dec 18, 2024

david-leifker Dec 18, 2024

david-leifker Dec 18, 2024

david-leifker Dec 18, 2024

david-leifker Dec 18, 2024

david-leifker Dec 18, 2024

		@@ -1,9 +1,11 @@
		package io.datahubproject.openapi;
		package io.datahubproject.openapi.config;

		@@ -0,0 +1,54 @@
		package io.datahubproject.openapi.operations.test;

		@@ -490,45 +492,3 @@ def getAccessTokenMetadata(session, token):
		response.raise_for_status()

		return response.json()

feat(api): authorization extended for soft-delete and suspend #12158

feat(api): authorization extended for soft-delete and suspend #12158

Conversation

david-leifker commented Dec 18, 2024 • edited Loading

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-leifker Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-leifker commented Dec 18, 2024 •

edited

Loading

david-leifker Dec 18, 2024 •

edited

Loading