feat(iceberg source): add config to ignore errors #12161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found that having the iceberg source fail on an exception was reducing the effectiveness of our source ingestion, especially when we don't care. This change adds a config to the iceberg source to allow you to ignore any exceptions that arise when DataHub parses iceberg tables. This allows the user to decide whether they want to be interrupted by errors.
github-actions
bot
added
ingestion
datahub-cyborg
bot
added
the
needs-review
|
This is not approach we would like to take. A separate PR will be raised to handle particular new type of exception experienced by @cccs-cat001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that having the iceberg source fail on an exception was reducing the effectiveness of our source ingestion, especially when we don't care.
This change adds a config to the iceberg source to allow you to ignore any exceptions that arise when DataHub parses iceberg tables. This allows the user to decide whether they want to be interrupted by errors.
Checklist