Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/mlflow): Support configurable base_external_url #12167

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat(ingest/mlflow): Support configurable base_external_url #12167

merged 1 commit into from
Dec 18, 2024

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from hsheth2 December 18, 2024 20:13
@asikowitz asikowitz changed the title feat(ingest/mlflow): Support onfigurable base_external_url feat(ingest/mlflow): Support configurable base_external_url Dec 18, 2024
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 18, 2024
@asikowitz asikowitz merged commit da8f822 into datahub-project:master Dec 18, 2024
120 of 130 checks passed
@asikowitz asikowitz deleted the mlflow-base-external-url branch December 18, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asikowitz @treff7es