Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Use python symlink from virtual env in all uv pip install commands #12183

Closed
wants to merge 3 commits into from

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Dec 19, 2024

Why

To allow for the development of DataHub in a consistent way across multiple OS'es and setups.

What

This change makes use of the symbolic link to the Python interpreter in the virtual environment's bin directory to maintain reliable package isolation and make the virtual environment more robust across different development environments.
The symlink ensures:

  • Environment portability by avoiding hardcoded paths to system Python
  • Consistent interpreter isolation when the virtual environment is activated

How

By adding the -p flag with the explicit Python executable path to all uv pip install commands across ingestion-related metadata-ingestion and the plugin modules (airflow, dagster, gx, prefect) build.gradle files:

Testing

This was tested using isolated environments based on Nix using https://www.jetify.com/devbox and bare metal EC2 ubuntu VMs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 19, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 19, 2024
@pedro93
Copy link
Collaborator Author

pedro93 commented Dec 20, 2024

After discussing with Harshal turns out this code change is not needed. Closing the PR.

@pedro93 pedro93 closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant