Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add more fine grained metrics for distinguishing between request sources #12188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RyanHolstien
Copy link
Collaborator

Adds the following metrics:

  • Accurate ingestProposal metric that accounts for batch sizes. Also splits into several metrics with sync/async + source API. These can be filtered with PromQL using "...ingestProposal_sync.", "...ingestProposal_async.", "...ingestProposal_sync_GRAPHQL", etc.
  • Finer grained metric for GraphQL based on user agent to allow for tracking true UI errors vs programmatic clients using GraphQL
  • Full MCL, MCP, & PE produce count
  • Preprocess count for UI based ingestion (things that skip waiting for MCL to be in ES indices)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien self-assigned this Dec 19, 2024
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Dec 19, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant