Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mssql): adds missing containers for dataflow and datajob entities, required for browse paths v2 generation #12194

Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix(mssql): adds missing containers for dataflow and datajob entities, required for browse paths v2 generation #12194

merged 1 commit into from
Dec 22, 2024

Conversation

sgomezvillamor
Copy link
Contributor

BrowsePathsV2 generation depends on the Container hierarchy, so this is adding missed Container aspect for the Data(Flow|DataJob) entities.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 20, 2024
@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 20, 2024 15:49
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 20, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 22, 2024
@anshbansal anshbansal merged commit 494c522 into master Dec 22, 2024
97 of 103 checks passed
@anshbansal anshbansal deleted the feature/cus-3452-fix-mssql-browsepaths branch December 22, 2024 12:21
anshbansal added a commit that referenced this pull request Dec 22, 2024
@anshbansal
Revert "fix(ingest/mssql): add container dataflow/ datajob entities (#…
5349f71 
…12194)"

This reverts commit 494c522.
@anshbansal anshbansal mentioned this pull request Dec 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @anshbansal