Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): use typing_extensions.Self #12230

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix(ingest): use typing_extensions.Self #12230

merged 1 commit into from
Dec 27, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 27, 2024

This was initially added in #7313 and then reverted in #7490. Now that we've dropped support for old Airflow versions in #12056, we can actually do the upgrade.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This was initially added in
#7313 and then reverted
in #7490. Now that we've
dropped support for old Airflow versions in
#12056, we can actually
do the upgrade.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 27, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 27, 2024
@hsheth2 hsheth2 changed the title fix(ingest): use typing_extensions.Self fix(ingest): use typing_extensions.Self Dec 27, 2024
@hsheth2 hsheth2 merged commit 4e3103e into master Dec 27, 2024
79 of 107 checks passed
@hsheth2 hsheth2 deleted the typing-self branch December 27, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants