fix(lineage): Fix issue where large lineage fetches trigger 414 URI too long #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
commented
Apr 26, 2021
| -Djava.security.auth.login.config=$CONF_DIR/jaas.conf | ||
| -Dlogback.configurationFile=$CURRENT_DIR/logback.xml | ||
| -Dlogback.debug=true | ||
| -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005" |
There was a problem hiding this comment.
intentionally committing this file to ease debug dev experience from now on.
…FixLineageOverloadingGMS
shirshanka
reviewed
Apr 27, 2021
| // not called | ||
| } | ||
|
|
||
| private static int batchSize = 25; |
shirshanka
reviewed
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue here: #2447
Ideally, we could send these ids as post data. However, restli client does not currently support this. As a temporary solution we can batch get our entity ids in size-limited batches.
Checklist