Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dbt): multiple node owner separated by comma #9645

Closed
wants to merge 1 commit into from
Closed

feat(dbt): multiple node owner separated by comma #9645

wants to merge 1 commit into from

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 17, 2024
hsheth2
hsheth2 reviewed Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd add this logic to mapping.py

datahub/metadata-ingestion/src/datahub/utilities/mapping.py

Line 277 in 4d9eb12

operation_type == Constants.ADD_OWNER_OPERATION

That way, it can also get used for kafka meta mappings / others in the future

Once that's done, can you also add a test case in test_mapping.py?

@anshbansal anshbansal closed this Jan 30, 2024
@anshbansal
Copy link
Collaborator Author

Superseded by #9740

@anshbansal anshbansal deleted the ab-allow-multiple-owner-dbt branch December 3, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @hsheth2