Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aspects): fix default aspect generation for non-restli locations #9746

Merged

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Jan 30, 2024

  • Consolidate Default Aspect logic to single utility class
    • Generate default aspects when a key aspect for an entity is not present
    • Do not create browsePath v1 when browsePath v2 is enabled
  • Move application of the default aspect creation from restli's AspectResource to EntityService.
  • (ebean) Serialize batches with key aspects per URN
  • Existing tests updated for the expected default aspects.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

_server = server;
if (enableLocking) {
this.locks =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure contains a lock per urn which expires after 1 minute. This lock which is used for the write patch is only used when a key aspect is found in a batch. Those batches will also contain all default aspects. These specific batches are serialized using the lock.

@david-leifker david-leifker merged commit ff0818b into datahub-project:master Feb 1, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants