-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aspects): fix default aspect generation for non-restli locations #9746
Merged
david-leifker
merged 3 commits into
datahub-project:master
from
david-leifker:fix-default-aspects
Feb 1, 2024
Merged
fix(aspects): fix default aspect generation for non-restli locations #9746
david-leifker
merged 3 commits into
datahub-project:master
from
david-leifker:fix-default-aspects
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
product
PR or Issue related to the DataHub UI/UX
devops
PR or Issue related to DataHub backend & deployment
labels
Jan 30, 2024
david-leifker
force-pushed
the
fix-default-aspects
branch
2 times, most recently
from
January 30, 2024 14:19
a1287d6
to
10f5828
Compare
david-leifker
force-pushed
the
fix-default-aspects
branch
from
January 30, 2024 16:19
10f5828
to
8ea0068
Compare
david-leifker
force-pushed
the
fix-default-aspects
branch
from
January 30, 2024 19:08
8ea0068
to
5c5fa09
Compare
david-leifker
force-pushed
the
fix-default-aspects
branch
from
January 30, 2024 20:29
5c5fa09
to
db01546
Compare
david-leifker
force-pushed
the
fix-default-aspects
branch
from
January 30, 2024 22:48
db01546
to
59d2944
Compare
david-leifker
commented
Jan 30, 2024
_server = server; | ||
if (enableLocking) { | ||
this.locks = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure contains a lock per urn which expires after 1 minute. This lock which is used for the write patch is only used when a key aspect is found in a batch. Those batches will also contain all default aspects. These specific batches are serialized using the lock.
david-leifker
force-pushed
the
fix-default-aspects
branch
from
January 31, 2024 01:53
59d2944
to
2c0daa9
Compare
RyanHolstien
approved these changes
Jan 31, 2024
metadata-io/src/main/java/com/linkedin/metadata/entity/ebean/EbeanAspectDao.java
Show resolved
Hide resolved
david-leifker
force-pushed
the
fix-default-aspects
branch
from
January 31, 2024 23:10
2c0daa9
to
2c65863
Compare
# Conflicts: # smoke-test/tests/cli/datahub_cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist