Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topics are on model now #407

Merged
merged 2 commits into from
Feb 5, 2024
Merged

topics are on model now #407

merged 2 commits into from
Feb 5, 2024

Conversation

fgregg
Copy link
Member

@fgregg fgregg commented Jan 27, 2024

Data is already added. this adjust the code to take advantage of it

closes #406

@fgregg fgregg requested a review from derekeder January 27, 2024 00:05
@derekeder derekeder temporarily deployed to chi-councilm-topics-on--c08hmd January 27, 2024 00:05 Inactive
Copy link
Member

@derekeder derekeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgregg testing this locally causes an error on the home page. looks like a number of bills don't have routine or topics in the extras field. I added a line to check for this, but the number affected is pretty high

@fgregg
Copy link
Member Author

fgregg commented Feb 2, 2024

there shouldn’t be any. should fix this in chicago-council-scrapers

@fgregg
Copy link
Member Author

fgregg commented Feb 5, 2024

there aren't any bills in the database without those fields. it's possible that there can be a small window between when the data is scraped and when this script runs. (like a few minutes).

@derekeder
Copy link
Member

looks like the topics are there now. might have been a temporary status when i tested on Friday. with the check I added, it won't error if they are missing, so i think we can merge this in.

@derekeder derekeder merged commit f26d93d into main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move topic classifier and store in OCD extras
2 participants