Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling some AttributeErrors #411

Merged
merged 2 commits into from
Mar 16, 2024
Merged

handling some AttributeErrors #411

merged 2 commits into from
Mar 16, 2024

Conversation

derekeder
Copy link
Member

Copy link

sentry-io bot commented Mar 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: chicago/views.py

Function Unhandled Issue
get_context_data ValueError: not enough values to unpack (expected 2, got 1) ...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

@derekeder derekeder temporarily deployed to chi-councilm-dwe-attrib-bdqqfo March 14, 2024 22:21 Inactive
@derekeder derekeder requested a review from fgregg March 15, 2024 16:42
@fgregg
Copy link
Member

fgregg commented Mar 15, 2024

hmm.. these seem like times when those objects should always have those attributes?

@derekeder
Copy link
Member Author

yes, I agree. we should handle this on the data side as well. i think these fixes are worth including as they currently are breaking the rss feed and some committee pages

@fgregg
Copy link
Member

fgregg commented Mar 15, 2024

that makes sense, let's have the errors be sent to sentry then in the condition that the attributes are missing.

@derekeder
Copy link
Member Author

ok i'll make that change

@derekeder derekeder temporarily deployed to chi-councilm-dwe-attrib-bdqqfo March 15, 2024 22:38 Inactive
@derekeder derekeder merged commit e587e77 into main Mar 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants