Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMM-14942] Support toggling registered model global flag #356

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

baekdahl
Copy link
Collaborator

@baekdahl baekdahl commented Oct 5, 2023

This repository is public. Do not put here any private DataRobot or customer's data, code, datasets, model artifacts, .etc.

RATIONAL

For the global models project, we want to support making registered models global.

CHANGES

  • Add global boolean value to model_registry in the schema.
  • Update global flag in model controller.

CAUTION: changing any of the checkbox states will immediately terminate a previous run that
is in progress.

  • Skip functional tests
  • Run all functional tests (>50 minutes)

NOTE: to run certain specific functional test(s), write a comment that includes the following
pattern $FUNCTIONAL_TESTS=<tests-to-run>. The test(s) specified after the assignment sign will be
executed. The execution can be viewed from the Actions tab.

@baekdahl
Copy link
Collaborator Author

baekdahl commented Oct 5, 2023

$FUNCTIONAL_TESTS=tests/functional/test_model_github_actions.py::TestModelGitHubActions::test_e2e_pull_request_event_with_multiple_changes

@baekdahl
Copy link
Collaborator Author

baekdahl commented Oct 5, 2023

$FUNCTIONAL_TESTS=tests/functional/test_model_github_actions.py::TestModelGitHubActions::test_e2e_pull_request_event_with_multiple_changes

@baekdahl baekdahl force-pushed the baekdahl/make-public branch from c3e0688 to c805fdc Compare October 23, 2023 10:10
Copy link
Collaborator

@zohar-mizrahi zohar-mizrahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW - not related to this PR, but is there a way to delete a model from the registry?
If so, it is currently not handled by the action, right?

@baekdahl
Copy link
Collaborator Author

@zohar-mizrahi Good point. To keep things simple, I haven't added support for handling deletes. Since there is no user provided id for registered models I don't see a good way to track which registered models to keep and which models to delete

@baekdahl baekdahl merged commit f3aa0a1 into master Oct 31, 2023
3 checks passed
@baekdahl baekdahl deleted the baekdahl/make-public branch October 31, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants