-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CFX-590] [CFX-539] Make Notebook custom environments to be compatible with custom models #1196
base: master
Are you sure you want to change the base?
Conversation
…e with custom models
The Needs Review labels were added based on the following file changes. Team @datarobot/custom-models (#custom-models) was assigned because of changes in files:public_dropin_notebook_environments/python311_notebook/Dockerfile public_dropin_notebook_environments/python311_notebook/requirements.txt public_dropin_notebook_environments/python311_notebook/start_server_drum.sh public_dropin_notebook_environments/python311_notebook_base/Dockerfile public_dropin_notebook_environments/python311_notebook_base/requirements.txt public_dropin_notebook_environments/python311_notebook_base/start_server_drum.sh public_dropin_notebook_environments/python39_notebook_gpu/Dockerfile public_dropin_notebook_environments/python39_notebook_gpu/requirements.txt public_dropin_notebook_environments/python39_notebook_gpu/start_server_drum.sh public_dropin_notebook_environments/python39_notebook_gpu_rapids/Dockerfile public_dropin_notebook_environments/python39_notebook_gpu_rapids/requirements.txt public_dropin_notebook_environments/python39_notebook_gpu_rapids/start_server_drum.sh public_dropin_notebook_environments/python39_notebook_gpu_tf/Dockerfile public_dropin_notebook_environments/python39_notebook_gpu_tf/requirements.txt public_dropin_notebook_environments/python39_notebook_gpu_tf/start_server_drum.sh Team @datarobot/nbx (#dr-notebooks) was assigned because of changes in files:public_dropin_notebook_environments/python311_notebook/Dockerfile public_dropin_notebook_environments/python311_notebook/requirements.txt public_dropin_notebook_environments/python311_notebook/start_server_drum.sh public_dropin_notebook_environments/python311_notebook_base/Dockerfile public_dropin_notebook_environments/python311_notebook_base/requirements.txt public_dropin_notebook_environments/python311_notebook_base/start_server_drum.sh public_dropin_notebook_environments/python39_notebook_gpu/Dockerfile public_dropin_notebook_environments/python39_notebook_gpu/requirements.txt public_dropin_notebook_environments/python39_notebook_gpu/start_server_drum.sh public_dropin_notebook_environments/python39_notebook_gpu_rapids/Dockerfile public_dropin_notebook_environments/python39_notebook_gpu_rapids/requirements.txt public_dropin_notebook_environments/python39_notebook_gpu_rapids/start_server_drum.sh public_dropin_notebook_environments/python39_notebook_gpu_tf/Dockerfile public_dropin_notebook_environments/python39_notebook_gpu_tf/requirements.txt public_dropin_notebook_environments/python39_notebook_gpu_tf/start_server_drum.sh If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I assume you intentionally didn't pin uwsgi
Only thing I'd say if it's at all important os that the different, newly added start server files have a copyright year of 2021 versus 2024 🤷
What is the plan on releasing these environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve while it is not released.
Label Needs Review: Custom Models was removed because @yakov-g is part of Custom Models domain. |
@yakov-g, added "customModel" to the list of use cases. Is it good to be released now? |
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Make Notebook custom environments to be compatible with Custom Models