Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'datashield/armadillo-rserver_caravan' and 'datashield/armadillo-rserver_caravan-volcano' #28

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

StuartWheater
Copy link
Member

No description provided.

Copy link

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StuartWheater what test do you expect here? It looks good.

Do you need one of us to locally run it?

@StuartWheater
Copy link
Member Author

I know little about the post "Pull Request" process as I don't have access to the Azure Pipeline results.
I have built the docker image by hand for this configuration, and put it in the Docker Hub for DataSHIELD.
That is what I have been testing.

Copy link

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the config; I noticed build is failing, is that blocking the merge?

@StuartWheater
Copy link
Member Author

I can't access the "details" of the check, so don't know the reason. I suspect it could be exceeding the time limit.

Copy link

@christianhilbrands christianhilbrands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StuartWheater What you could try to do is to increase the timeout in the azure-pipelines.yaml. See: https://github.com/datashield/docker-armadillo-rserver-base/blob/main/azure-pipelines.yml#L9

@StuartWheater
Copy link
Member Author

Yes, the timeout can be extended and number of cpus used by R increased.
I have also created a branch in my fork of the repo which is using 'make' to create the images.
Stuart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants