Allows using Collection and/or UDT fields for ttl & writetime calculations #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pravinbhat
requested review from
jeromatron,
Jeremya,
mfmaher2 and
faizalrub-datastax
pravinbhat
changed the title
msmygit
approved these changes
Oct 18, 2024
|
|
||
| # Max WRITETIME value of specified non-PK columns will be used for insert on target (overrides automatic setting) | ||
| #spark.cdm.schema.origin.column.writetime.names data_col1,data_col2,... | ||
| #spark.cdm.schema.origin.column.names.to.target partition_col1:partition_col_1,partition_col2:partition_col_2,... | ||
| spark.cdm.schema.ttlwritetime.calc.useCollections false |
There was a problem hiding this comment.
nitpick - can we get rid of the camelCase here?
There was a problem hiding this comment.
All multi-word phrases (keyspaceTable, runId, numParts, batchSize, splitRegex, etc.) are currently use camel case, so sticking with that standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Allows using Collection and/or UDT fields for
ttl&writetimecalculations. This is specifically helpful in scenarios where the only non-key columns are Collections and/or UDTs.Which issue(s) this PR fixes:
Fixes #300
Checklist: