Major refactor to make CDM Spark Native #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature and renamed slices/partitions to PartitionRanges. Also provided actual jobs access to PartitionRange class.
# Conflicts: None
…proved trackRun feature.
# Conflicts: # src/main/java/com/datastax/cdm/cql/statement/TargetUpsertRunDetailsStatement.java # src/main/java/com/datastax/cdm/feature/TrackRun.java # src/main/java/com/datastax/cdm/job/CopyJobSessionFactory.java # src/main/java/com/datastax/cdm/job/DiffJobSessionFactory.java # src/main/java/com/datastax/cdm/job/GuardrailCheckJobSessionFactory.java # src/main/java/com/datastax/cdm/job/PartitionRange.java # src/main/java/com/datastax/cdm/job/SplitPartitions.java # src/main/scala/com/datastax/cdm/job/DiffData.scala # src/main/scala/com/datastax/cdm/job/GuardrailCheck.scala # src/main/scala/com/datastax/cdm/job/Migrate.scala # src/test/java/com/datastax/cdm/cql/statement/TargetUpsertRunDetailsStatementTest.java # src/test/java/com/datastax/cdm/feature/TrackRunTest.java # src/test/java/com/datastax/cdm/job/SplitPartitionsTest.java
pravinbhat
requested review from
jeromatron,
Jeremya,
mfmaher2 and
faizalrub-datastax
mfmaher2
approved these changes
Nov 8, 2024
msmygit
approved these changes
Nov 8, 2024
| @@ -29,7 +30,10 @@ object DiffData extends BasePartitionJob { | |||
| if (!parts.isEmpty()) { | |||
| originConnection.withSessionDo(originSession => | |||
| targetConnection.withSessionDo(targetSession => | |||
| jobFactory.getInstance(originSession, targetSession, propertyHelper).initCdmRun(runId, prevRunId, parts, trackRunFeature, JobType.VALIDATE))); | |||
| jobFactory.getInstance(originSession, targetSession, propertyHelper).initCdmRun(runId, prevRunId, parts, trackRunFeature, jobType))); | |||
| var ma = new CDMMetricsAccumulator(jobType) | |||
There was a problem hiding this comment.
should we move these 2 lines to the BasePartitionJob class instead? And, remove from these 3 class files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Major refactor to make CDM Spark Native, fixed metrics reporting bug & also improved trackRun feature.
Checklist: