Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-11144: Support compilation and testing with j22 (by Ekaterina and co) #1323

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

jacek-lewandowski
Copy link
Collaborator

@jacek-lewandowski jacek-lewandowski commented Oct 3, 2024

DON'T CONSIDER THIS AS DONE

DON'T BE TEMPTED TO MERGE IT

ekaterinadimitrova2 and others added 30 commits October 3, 2024 13:42
patch by Ekaterina Dimitrova; reviewed by Michaem Semb Wever for CASSANDRA-17224
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena and Michael Semb Wever for CASSANDRA-18267
…roperties `java.default` and `java.supported`.

ant generate-idea-files now support JDK 8, JDK 11 and JDK 22.
To add support of another JDK the java-jvmargs property must be set for the JDK in question (see how it's done in build.xml for Java 11 and 22)

Other minor, but notable changes are:
- test jvmargs are now added to idea run configurations
- .idea dir and project iml file are first removed and then recreated during `ant generate-idea-files`

Based on what was done in CASSANDRA-18467, CASSANDRA-18179, CASSANDRA-18258 for 17 plus additional stuff for 21

Co-authored-by: Ekaterina Dimitrova<[email protected]>
Co-authored-by: Mick Semb Wever <[email protected]>
Co-authored-by: Jakub Zytka <[email protected]>
…jvm options, to match the order in the other files/places

There is a chance this fixes some tests (or breakes more?)
…ASSANDRA-18723 but I figured I want to stay more conservative for this branch. This bump requires more testing than only the unit testing. Also, it looks like that some netty defaults have changed before and we agreed with that. (In Cassandra we added io.netty.allocator.useCacheForAllThreads=true, io.netty.allocator.maxOrder=11, this was not done here)
patch by Stefan Miklosovic; reviewed by Andrés de la Peña for CASSANDRA-18152

Fix for org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest
…lassCastException on JDK17

Fix ClassCastException  from jdk GaloisCounterMode when using JDK17 provider

Add javac exports to build.xml for java.base/jdk.internal.ref and java.base/sun.nio.ch

Replace checktestnameshelper ant task in build.xml with _check-test-names java target to be able to pass jvm args to TestNameCheckTask

patch by Dan Janieks; revewed by Ekaterina Dimitrova and Andres de la Pena for CASSANDRA-18180
…l want to check newer version for JDK22 specifically
This upgrade also fixes issues with PhantomReferences and the test problems from CASSANDRA-17884 anad CASSANDRA-16304

patch by Benjamin Lerer; reviewed by Ekaterina Dimitrova for CASSANDRA-18239
…revision and work if we decide to do it here; the cherry-pick was quick for testing without spending too much time on details
ekaterinadimitrova2 and others added 5 commits October 3, 2024 13:43
…horough revision and work if we decide to do it here; the cherry-pick was quick for testing without spending too much time on details"

This reverts commit b160b80.
…hrough then worked 2nd. Forking it fixes this.
@ekaterinadimitrova2
Copy link

FYI THE PATCH IS ONLY FOR EXPERIMENTATION PURPOSES AT THE MOMENT! NO REVIEWS OR MERGE!

If anyone wants to know details - please ping me or @jacek-lewandowski

@jacek-lewandowski jacek-lewandowski marked this pull request as draft October 3, 2024 13:13
@ekaterinadimitrova2 ekaterinadimitrova2 marked this pull request as ready for review October 3, 2024 18:02
@ekaterinadimitrova2 ekaterinadimitrova2 marked this pull request as draft October 3, 2024 18:06
@ekaterinadimitrova2
Copy link

Pushed one new jamm-related commit.
Started CI here - https://jenkins-stargazer.aws.dsinternal.org/view/cc-builds/job/ds-cassandra-build/829/
Unit tests with compression and distributed ones; JDK 22 - build and run

Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Remove --add-opens java.base/java.nio=ALL-UNNAMED which is not needed anymore

patch by Ekaterina Dimitrova; reviewed by Jacek Lewandowki for CASSANDRA-17909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants