-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored colbert codebase #407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antora site build successful! ✅ |
epinzur
force-pushed
the
colbert-cpu
branch
2 times, most recently
from
May 9, 2024 17:06
2221393
to
4cde7a2
Compare
epinzur
changed the title
DRAFT: cleaned up colbert embedding execution
refactored colbert codebase
May 9, 2024
epinzur
commented
May 9, 2024
zzzming
reviewed
May 10, 2024
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nest_asyncio.apply()
there. It should NOT be in our package.beProbably more stuff that I'm forgetting...
There is still some more stuff to implement on the llamaindex side, but I'd love to get a release out that is working for langchain users.
Also I'll add more robust testing later.