Skip to content

Commit

Permalink
Release 1.1.1 (#17)
Browse files Browse the repository at this point in the history
## Release notes

* fix: add data-cy to login username, password and submit
(#16)

### Release dependencies first

In case of dependent Phovea/TDP repositories follow [dependency
tree](https://wiki.datavisyn.io/phovea/fundamentals/development-process#dependency-hierarchy)
from the top:

 
### 🏁 Finish line

* [ ] Inform colleagues and customers about the release
* [ ] Celebrate the new release 🥳
  • Loading branch information
puehringer authored Apr 3, 2023
2 parents f8da398 + 3f202b8 commit 50a4796
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "visyn_core",
"description": "Core repository for datavisyn applications.",
"version": "1.1.0",
"version": "1.1.1",
"author": {
"name": "datavisyn GmbH",
"email": "[email protected]",
Expand Down Expand Up @@ -158,7 +158,7 @@
"react-highlight-words": "^0.17.0",
"react-plotly.js": "^2.5.1",
"use-deep-compare-effect": "^1.8.0",
"visyn_scripts": "^3.0.0"
"visyn_scripts": "^3.0.1"
},
"devDependencies": {
"@babel/core": "^7.17.7",
Expand Down
13 changes: 11 additions & 2 deletions src/app/login/VisynLoginForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,17 @@ export function VisynLoginForm({ onLogin }: { onLogin: (username: string, passwo
return (
<form onSubmit={form.onSubmit((values) => onLogin(values.username, values.password))}>
<Stack>
<TextInput placeholder="Username" label="Username" name="username" autoComplete="username" {...form.getInputProps('username')} required />
<TextInput
data-cy="visyn-login-username"
placeholder="Username"
label="Username"
name="username"
autoComplete="username"
{...form.getInputProps('username')}
required
/>
<TextInput
data-cy="visyn-login-password"
type={isShowPassword ? 'text' : 'password'}
placeholder="Password"
label="Password"
Expand All @@ -34,7 +43,7 @@ export function VisynLoginForm({ onLogin }: { onLogin: (username: string, passwo
/>
</Stack>
<Group position="right">
<Button fullWidth={false} mt="md" type="submit" className="btn btn-primary">
<Button data-cy="visyn-login-submit" fullWidth={false} mt="md" type="submit" className="btn btn-primary">
Login
</Button>
</Group>
Expand Down

0 comments on commit 50a4796

Please sign in to comment.