Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add numerical column support to bar plot #272

Closed
wants to merge 33 commits into from
Closed

feat: add numerical column support to bar plot #272

wants to merge 33 commits into from

Conversation

dv-usama-ansari
Copy link
Contributor

Closes #89

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified @thinkh @dvchristianbors
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • TBD

Screenshots

  • TBD

Additional notes for the reviewer(s)

  • N/A

dvmartinweigl and others added 30 commits April 23, 2024 15:30
@dvmartinweigl
fix violin plot selection
7266c43
@dvmartinweigl
partial fix vis stories
5f5eb65
@dvmartinweigl
move null value filtering to trace creation function
1c964e9
@dvmartinweigl
disable zoom for violin plot
8615971
@dvmartinweigl
small refactor
48943a8
@dvmartinweigl
pin storybook/node-logger
7372eff
@dvmartinweigl
remove resolution
c346ddc
@dvmartinweigl
small useEffect dependency array fix
31e4569
@dv-usama-ansari
feat(wip): add numerical column selection to bar plot
493c090 
wip: update axis to use numerical columns
@dv-usama-ansari
fix: domain and range for numerical scales
a6fd9a7
@dv-usama-ansari
fix: tooltip text
8443522
@dv-usama-ansari
refactor: update SingleSelect to support multiple column types
9a7046a
@dv-usama-ansari
refactor: use new SingleSelect implementation
a2d147f
@dv-usama-ansari
chore: update bar merge default config
aed1b05
@dv-usama-ansari
style: use full size vis components
aafcb5d
@dv-usama-ansari
feat: update sidebar to have column type aware options
9fa4ba4
@dv-usama-ansari
fix: bar selection and sizing issues
5038a42
@dv-usama-ansari
fix: infinite rendering in sidebar
10f6ec5
@dv-usama-ansari
chore: update x and y axes
5533969
@dvchristianbors
Merge remote-tracking branch 'origin/develop' into ua/89-bar-plot
082aa5f
@dv-usama-ansari
refactor: set domain to [most-negative, 0], [0, most positive] and [m…
df1275d 
…ost-negative, most positive]
@dv-usama-ansari
style: rotate x axis labels
4625ffe
@dv-usama-ansari
fix: update axes to use the new ticks
ae205f4
@dv-usama-ansari
chore(wip): update sorting logic for the axes
bcde224 
wip: test sorting logic for the axes
@dv-usama-ansari
feat: smartly rotate axis text
6a6bc64
@dv-usama-ansari
style: make select consistent with others
e7f53c9
@dv-usama-ansari
chore: set 20 items cap for categorical and 100 for numerical columns
f201cf4
@dv-usama-ansari
chore: rename multiples to facets
4f6135e
@dv-usama-ansari
fix: adjust bar boundaries for negative as well as positive values
92b5458
@dv-usama-ansari
feat: change search criteria for columns to match id
47f7792
@dv-usama-ansari
Copy link
Contributor Author

Closing this in favor of #497

@dv-usama-ansari dv-usama-ansari mentioned this pull request Sep 13, 2024
Merged
17 tasks
@thinkh thinkh deleted the ua/89-bar-plot branch October 24, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar plot
3 participants
@dv-usama-ansari @dvmartinweigl @dvchristianbors