-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow user defined pull request number #369
allow user defined pull request number #369
Conversation
It would be amazing to get this merged 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR. Overall, it looks great and I only left a few minor comments to address.
Big thank you for also fixing some of the formatting. I really should add some ESLint and Prettier 😅
Co-authored-by: David Losert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you very much for this.
I'll merge and release this for now, as it has been sitting and waiting for long enough 🙂
# [2.4.0](v2.3.1...v2.4.0) (2024-06-11) ### Features * allow user defined pull request number ([#369](#369)) ([9455b83](9455b83))
🎉 This PR is included in version 2.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
As discussed in Issue #365 , here is the pull request for the feature of allowing a user-defined pull request number.
If there is a user-defined pull request number, and the pull request number cannot be found from the context, it will use the user-defined PR number.
By the way: thanks for creating this GitHub Action! It helps us a lot.