feat: Pass PR number to the getPullChanges #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can get file coverage report without relying on the context.
mihaerzen
force-pushed
the
respect-pr-from-config
branch
from
177504a to
33258a8
Compare
|
@davelosert Any chance I can get this reviewed? |
davelosert
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
@mihaerzen : Great catch and thank you very for this, great work!
I just reverted the /dist files as they are actually rebuild during the release process - besides that, I will merge it as it is (I am currently in a major refactoring for this, so I will do some minor changes myself during that).
|
@davelosert Perfect! Yeah I was unsure about the |
|
Amazing, this works already! Thank you @davelosert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all 👋
In our CI, we are running our job on every push. This means we are relying on passing the PR number via
pr-numbervariable. I have noticed, this was not respected in thegetPullChangesmethod, so I added it. I also added some tests for the functionality added. Let me know if I missed something obvious!Thank you 🤝