Fixes "Coverage Trend Indicator" workflow for PRs with slash ('/') in name #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the name
Artifacts cannot have forward slashes ('/') in the name, which causes dependabot tests to fail and could also impact gitflow and other systems that use slashes in the branch names.
davelosert
approved these changes
Nov 17, 2024
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "Coverage Trend Indicator" workflow example so that it will run successfully in with dependabot PR's and (more generally) any PR with a slash (/) in it's name.
Background: Artifacts (
actions/upload-artifact) cannot have forward slashes ('/') in the name. As such, dependabot PRs will fail, as could other git branch naming systems like gitflow and others (that use slashes in the branch names).The fix involves explicitly naming the artifacts by using
strategy.matrix.includeto specify thebranchname to checkout andartifactname to upload.