godoc/static: add gopher/pkg.png image

Replace the link to the gopher pkg.png from an online location to a local file. This will prevent any privacy issue on godoc so that there is no ping anymore to golang.org when opening private documentation generated by godoc. Another benefit is that it allows the image to load when godoc is used offline. Last the img is placed to the upper section. For golang/go#32011. Change-Id: I1459bf2613251e3e12404087ea9083b64a4f70c2 GitHub-Last-Rev: c32ef95 GitHub-Pull-Request: golang#315 Reviewed-on: https://go-review.googlesource.com/c/tools/+/313097 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]> Trust: Cherry Mui <[email protected]>
daveset · May 7, 2021 · f05e912 · f05e912
1 parent c0140e8
commit f05e912
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/godoc/static/gen.go b/godoc/static/gen.go
@@ -38,6 +38,7 @@ var files = []string{
 	"favicon.ico",
 	"godoc.html",
 	"godocs.js",
+	"gopher/pkg.png",
 	"images/minus.gif",
 	"images/plus.gif",
 	"images/treeview-black-line.gif",

diff --git a/godoc/static/gopher/pkg.png b/godoc/static/gopher/pkg.png
diff --git a/godoc/static/packageroot.html b/godoc/static/packageroot.html
@@ -21,6 +21,7 @@
 		<h2 id="pkg-subdirectories">Subdirectories</h2>
 	{{end}}
 		<div id="manual-nav">
+			<img alt="" class="gopher" src="/lib/godoc/gopher/pkg.png"/>
 			<dl>
 				<dt><a href="#stdlib">Standard library</a></dt>
 				{{if hasThirdParty .List }}
@@ -38,7 +39,6 @@ <h2 class="toggleButton" title="Click to show Standard library section">Standard
 			</div>
 			<div class="expanded">
 				<h2 class="toggleButton" title="Click to hide Standard library section">Standard library ▾</h2>
-				<img alt="" class="gopher" src="https://golang.org/doc/gopher/pkg.png"/>
 				<div class="pkg-dir">
 					<table>
 						<tr>

diff --git a/godoc/static/static.go b/godoc/static/static.go
diff --git a/godoc/static/style.css b/godoc/static/style.css
@@ -403,12 +403,6 @@ div#about {
   font-size: 1.25rem;
   margin: 0 auto 1.875rem;
 }
-div#gopher {
-  background: url(https://golang.org/doc/gopher/frontpage.png) no-repeat;
-  background-position: center top;
-  height: 9.688rem;
-  max-height: 200px; /* Setting in px to prevent the gopher from blowing up in very high default font-sizes */
-}
 a#start {
   display: block;
   padding: 0.625rem;
@@ -582,6 +576,7 @@ hr {
 img.gopher {
   float: right;
   margin-left: 0.625rem;
+  margin-top: -2.5rem;
   margin-bottom: 0.625rem;
   z-index: -1;
 }